Health endpoint reports 'Alonzo' even in the 'Babbage' era.

[KtorZ]

What Git revision are you using?

v5.5.0

What operating system are you using, and which version?

• Linux / Ubuntu
• Linux / Other
• OSX
• Windows

Describe what the problem is?

"lastTipUpdate":"2022-07-03T21:12:13.666894572Z","networkSynchronization":0.99999,"currentEra":"Alonzo","metrics":{"activeConnections":0,"runtimeStats":{"cpuTime":6686436,"currentHeapSize":0,"gcCpuTime":0,"maxHeapSize":0},"sessionDurations":{"max":0,"mean":0,"min":0},"totalConnections":0,"totalMessages":0,"totalUnrouted":0},"connectionStatus":"connected","currentEpoch":215,"slotInEpoch":3064}}},"version":"v5.5.0"}

Current era is still Alonzo in ogmios after Vasil HF.

What should be the expected behavior?

Reported era should be Babbage in this case, because the testnet has forked.

Solution

Culprit is:

ogmios/server/src/Ogmios/App/Health.hs

Lines 358 to 364 in 237b4ea

	notifyResult $ case eraIndexToInt eraIndex of
	0 -> Byron
	1 -> Shelley
	2 -> Allegra
	3 -> Mary
	_ -> Alonzo
	continue

which doesn't raise any warning or error for the wildcard pattern-match. This is unfortunate since the EraIndex already is a well-typed sum-of-product 😬 ... so instead of converting to an open type (here, Int), we should instead pattern match on the era index.