Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript client: isomorphic websocket browser detection #273

Closed
wants to merge 1 commit into from
Closed

Typescript client: isomorphic websocket browser detection #273

wants to merge 1 commit into from

Conversation

szist
Copy link
Contributor

@szist szist commented Oct 15, 2022

process gets injected by several tooling applications (e.g. create-react-app). Using it for detection causes the websocket connection to always use the node version.

The modified version comes from browser-or-node npm package.

@KtorZ
Copy link
Member

KtorZ commented Oct 21, 2022

Hey! Thanks for PR! It's been merged manually as part of: 45655b6

@KtorZ KtorZ closed this Oct 21, 2022
@szist szist deleted the browser-detection branch October 21, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants