Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for parsing the remaining fields in the Connection Header #111

Open
ssnover opened this issue Sep 1, 2023 · 1 comment
Open
Labels
enhancement New feature or request good first issue Good for newcomers ros1 For issues affecting the native ROS1 implementation

Comments

@ssnover
Copy link
Collaborator

ssnover commented Sep 1, 2023

Currently missing a couple (see tcpros.rs), however I didn't see these in the packet capture coming from the subscriber node so they're documented but maybe unused in practice.

@ssnover ssnover added enhancement New feature or request good first issue Good for newcomers ros1 For issues affecting the native ROS1 implementation labels Sep 1, 2023
@Carter12s
Copy link
Owner

Note: through my various work on services a lot of fields were added, but things definitely look funky and the whole header could stand to get a once over. A lot of the fields are optional in different ways in different contexts, so we may want a PublisherAdvertiseHeader, and ServiceClientConnectHeader etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers ros1 For issues affecting the native ROS1 implementation
Projects
None yet
Development

No branches or pull requests

2 participants