Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated App static class. #283

Open
ymh199478 opened this issue Jan 7, 2020 · 0 comments
Open

Deprecated App static class. #283

ymh199478 opened this issue Jan 7, 2020 · 0 comments
Assignees
@ymh199478
Labels
3.0
Milestone
3.0

Comments

@ymh199478
Copy link
Contributor

ymh199478 commented Jan 7, 2020 •
edited
Loading

App exists for historical reasons. Now we need to deprecate App class for the following reasons:

  • Static functions should be thread-safe, but App are not.
  • App objects induce developers to write code that depends on CatLib.
  • App corresponding instance may change.
  • App has gradually become God's object
@ymh199478 ymh199478 self-assigned this Jan 7, 2020
@ymh199478 ymh199478 removed the Feature label Jan 7, 2020
@ymh199478 ymh199478 changed the title [Proposal] Deprecated App static class. Deprecated App static class. Feb 10, 2020
@ymh199478 ymh199478 added 3.0 and removed Need Review labels Feb 10, 2020
@ymh199478 ymh199478 added this to the 3.0 milestone Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ymh199478 ymh199478

Labels
3.0
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
1 participant
@ymh199478