[HOUSEKEEPING] Resolve eslint error and warning (#409)

* remove disable eslint

* next round

* more fixes

* resolve conflict

* more lint fixes

* added more tests

* more lint errors

Author: dennisseah

src/commands/command.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-use-before-define */
 import commander from "commander";
 import { enableVerboseLogging, logger } from "../logger";
 
@@ -17,6 +16,33 @@ interface Command {
   subCommands: Command[];
 }
 
+/**
+ * Links the command and sub-commands in the passed IComponent together.
+ * Adding the necessary command/actions for each sub-command to the parent.
+ *
+ * Note: this linking isn't what actually enables nested sub-command calling,
+ * this is only used for displaying what sub-commands are available for any
+ * given parent. For information on how sub-commands are executed refer to
+ * `executeCommand`
+ *
+ * @param c ICommand object to prepare
+ */
+const linkSubCommands = (c: Command): Command => {
+  const { command, subCommands } = c;
+  // Add all sub-commands
+  for (const subCommand of subCommands) {
+    // Recur; link all sub-sub-commands to the sub-command before adding to current
+    linkSubCommands(subCommand);
+
+    // Add the subCommand to command
+    command
+      .command(subCommand.command.name())
+      .description(subCommand.command.description());
+  }
+
+  return c;
+};
+
 /**
  * Generates an concrete implementation of ICommand.
  *
@@ -118,30 +144,3 @@ export const executeCommand = (cmd: Command, argv: string[]): void => {
     }
   }
 };
-
-/**
- * Links the command and sub-commands in the passed IComponent together.
- * Adding the necessary command/actions for each sub-command to the parent.
- *
- * Note: this linking isn't what actually enables nested sub-command calling,
- * this is only used for displaying what sub-commands are available for any
- * given parent. For information on how sub-commands are executed refer to
- * `executeCommand`
- *
- * @param c ICommand object to prepare
- */
-const linkSubCommands = (c: Command): Command => {
-  const { command, subCommands } = c;
-  // Add all sub-commands
-  for (const subCommand of subCommands) {
-    // Recur; link all sub-sub-commands to the sub-command before adding to current
-    linkSubCommands(subCommand);
-
-    // Add the subCommand to command
-    command
-      .command(subCommand.command.name())
-      .description(subCommand.command.description());
-  }
-
-  return c;
-};

src/commands/deployment/create.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-non-null-assertion */
 import commander from "commander";
 import {
   addSrcToACRPipeline,
@@ -66,6 +65,7 @@ export const handlePipeline1 = async (
   }
   await addSrcToACRPipeline(
     tableInfo,
+    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
     opts.p1!,
     opts.imageTag,
     opts.service,
@@ -89,6 +89,7 @@ export const handlePipeline2 = async (
   }
   await updateACRToHLDPipeline(
     tableInfo,
+    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
     opts.p2!,
     opts.imageTag,
     opts.hldCommitId,
@@ -113,9 +114,13 @@ export const execute = async (
     validateValues(opts);
 
     const tableInfo: DeploymentTable = {
+      // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
       accountKey: opts.accessKey!,
+      // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
       accountName: opts.name!,
+      // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
       partitionKey: opts.partitionKey!,
+      // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
       tableName: opts.tableName!
     };
 
@@ -126,7 +131,9 @@ export const execute = async (
     } else if (hasValue(opts.p3) && hasValue(opts.hldCommitId)) {
       await updateHLDToManifestPipeline(
         tableInfo,
+        // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
         opts.hldCommitId!,
+        // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
         opts.p3!,
         opts.manifestCommitId,
         opts.pr,

src/commands/deployment/dashboard.test.ts

@@ -1,5 +1,3 @@
-/* eslint-disable @typescript-eslint/no-non-null-assertion */
-/* eslint-disable @typescript-eslint/camelcase */
 jest.mock("open");
 import open from "open";
 jest.mock("../../config");
@@ -32,18 +30,18 @@ afterAll(() => {
 
 const mockConfig = (): void => {
   (Config as jest.Mock).mockReturnValueOnce({
-    azure_devops: {
-      access_token: uuid(),
+    "azure_devops": {
+      "access_token": uuid(),
       org: uuid(),
       project: uuid()
     },
     introspection: {
       azure: {
-        account_name: uuid(),
+        "account_name": uuid(),
         key: uuid(),
-        partition_key: uuid(),
-        source_repo_access_token: "test_token",
-        table_name: uuid()
+        "partition_key": uuid(),
+        "source_repo_access_token": "test_token",
+        "table_name": uuid()
       }
     }
   });
@@ -134,6 +132,7 @@ describe("Validate dashboard container pull", () => {
         const dockerId = await exec("docker", [
           "images",
           "-q",
+          // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
           config.introspection!.dashboard!.image!
         ]);
         expect(dockerId).toBeDefined();
@@ -160,6 +159,7 @@ describe("Validate dashboard clean up", () => {
         const dockerId = await exec("docker", [
           "images",
           "-q",
+          // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
           config.introspection!.dashboard!.image!
         ]);
 
@@ -185,6 +185,7 @@ describe("Fallback to azure devops access token", () => {
     const envVars = (await getEnvVars(config)).toString();
     logger.info(
       `spin: ${envVars}, act: ${
+        // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
         config.introspection!.azure!.source_repo_access_token
       }`
     );
@@ -198,6 +199,7 @@ describe("Fallback to azure devops access token", () => {
     const envVars = (await getEnvVars(config)).toString();
     const expectedSubstring =
       "REACT_APP_SOURCE_REPO_ACCESS_TOKEN=" +
+      // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
       config.introspection!.azure!.source_repo_access_token!;
     expect(envVars.includes(expectedSubstring)).toBeTruthy();
   });
@@ -206,21 +208,26 @@ describe("Fallback to azure devops access token", () => {
 describe("Extract manifest repository information", () => {
   test("Manifest repository information is successfully extracted", () => {
     (Config as jest.Mock).mockReturnValue({
-      azure_devops: {
-        manifest_repository:
+      "azure_devops": {
+        "manifest_repository":
           "https://dev.azure.com/bhnook/fabrikam/_git/materialized"
       }
     });
     const config = Config();
     let manifestInfo = extractManifestRepositoryInformation(config);
     expect(manifestInfo).toBeDefined();
+    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
     expect(manifestInfo!.githubUsername).toBeUndefined();
+    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
     expect(manifestInfo!.manifestRepoName).toBe("materialized");
-    config.azure_devops!.manifest_repository =
+    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+    config.azure_devops!["manifest_repository"] =
       "https://github.com/username/manifest";
     manifestInfo = extractManifestRepositoryInformation(config);
     expect(manifestInfo).toBeDefined();
+    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
     expect(manifestInfo!.githubUsername).toBe("username");
+    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
     expect(manifestInfo!.manifestRepoName).toBe("manifest");
 
     logger.info("Verified that manifest repository extraction works");