Support newer versions of axios?

[papandreou]

Hi, I'm using axios-ntlm via the soap module. I noticed that I end up with an older version of axios (latest is 0.27.2, I'm getting 0.21.4):

$ npm ls axios
[...]
└─┬ soap@0.45.0
  ├─┬ axios-ntlm@1.3.0
  │ └── axios@0.21.4 deduped
  └── axios@0.21.4

(npm version 8.12.1, node version 18.5.0)

soap has a peer dep on axios@>=0.21.1, but because of axios-ntlm's peer dep on axios@^0.21.3, npm installs 0.21.4. It's because ^ only matches 0.21.3 and 0.21.4 due to the pre-1.0.0 version number:

So I guess what I'm asking is: Does axios-ntlm support newer versions of axios, and if so, could we make the peer dep more liberal so that users can use newer version without adding an override to package.json? 🤗

[gustavogialim]

@papandreou nice point, also I was getting an error with the current axios version used by axios-ntlm.

The error:

TypeError: Cannot read properties of undefined (reading 'create')
    at new HttpClient (/app/node_modules/soap/src/http.ts:42:52)
    at new Client (/app/node_modules/soap/src/client.ts:77:45)
    at /app/node_modules/soap/src/soap.ts:84:27
    at WSDL.callback (/app/node_modules/soap/src/soap.ts:37:9)
    at /app/node_modules/soap/src/wsdl/index.ts:149:16
    at WSDL._processNextInclude (/app/node_modules/soap/src/wsdl/index.ts:1189:14)
    at WSDL.processIncludes (/app/node_modules/soap/src/wsdl/index.ts:173:10)
    at /app/node_modules/soap/src/wsdl/index.ts:101:12
    at processTicksAndRejections (node:internal/process/task_queues:78:11)

My temporary fix to it is override the axios version in the package.json:

"overrides": {
    "soap": {
      "axios-ntlm": {
        "axios": "^0.27.2"
      },
      "axios": "^0.27.2"
    }
  }

Would be great to review this question in this lib and fix it :)
If I get sometime some day I can try to open a Merge Request.

[papandreou]

Ping @Catbuttes 🤗

[vision10]

axios is at latest 1.3.2