Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove APIs deprecated in Android 15 #2299

Open
TheLastProject opened this issue Jan 16, 2025 · 1 comment
Open

Remove APIs deprecated in Android 15 #2299

TheLastProject opened this issue Jan 16, 2025 · 1 comment
Labels
common: frequent Affects or can be seen by most users regularly or impacts most users' first experience severity: critical Prevents work, causes data loss and/or has no workaround type: bug Something isn't working

Comments

@TheLastProject
Copy link
Member

Google Play is complaining about this. Mindlessly removing it hasn't worked (because it breaks Android 14 stuff) so we need to look at what we can do:

Your app uses deprecated APIs or parameters for edge-to-edge

One or more of the APIs you use or parameters that you set for edge-to-edge and window display have been deprecated in Android 15. Your app uses the following deprecated APIs or parameters:

android.view.Window.setDecorFitsSystemWindows
androidx.core.view.WindowCompat$Api35Impl.setDecorFitsSystemWindows
androidx.core.view.WindowCompat.setDecorFitsSystemWindows
android.view.Window.setStatusBarColor
android.view.Window.setNavigationBarColor
com.yalantis.ucrop.UCropActivity.setStatusBarColor
com.yalantis.ucrop.UCrop$Options.setStatusBarColor

These start in the following places:

androidx.core.view.WindowCompat$Api35Impl.setDecorFitsSystemWindows
androidx.core.view.WindowCompat.setDecorFitsSystemWindows
com.google.android.material.internal.EdgeToEdgeUtils.applyEdgeToEdge
com.yalantis.ucrop.UCropActivity.setStatusBarColor
com.yalantis.ucrop.UCropActivity.setupAppBar
protect.card_locker.CatimaAppCompatActivity.onPostCreate
protect.card_locker.LoyaltyCardEditActivity.setCropperOptions
protect.card_locker.LoyaltyCardViewActivity$$ExternalSyntheticApiModelOutline1.m
protect.card_locker.Utils.setNavigationBarColor

To fix this, migrate away from these APIs or parameters.

(Of course, the com.yalantis.ucrop we can't do anything about, that's part of https://github.com/Yalantis/uCrop. We may need to pick a different library if they don't fix their side)

@TheLastProject TheLastProject added type: bug Something isn't working severity: critical Prevents work, causes data loss and/or has no workaround common: frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Jan 16, 2025
@TheLastProject
Copy link
Member Author

It seems that uCrop is broken on Android 15 and displays the save button on the title bar. That's not great.

https://github.com/jens-muenker/uCrop-n-Edit seems to be a more maintained fork, investigate switching to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common: frequent Affects or can be seen by most users regularly or impacts most users' first experience severity: critical Prevents work, causes data loss and/or has no workaround type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant