Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diepAPI.apis.scaling.toCanvasPos() not perfect #49

Closed
Cazka opened this issue Oct 9, 2022 · 1 comment · Fixed by #51
Closed

diepAPI.apis.scaling.toCanvasPos() not perfect #49

Cazka opened this issue Oct 9, 2022 · 1 comment · Fixed by #51
Labels
bug Something isn't working

Comments

@Cazka
Copy link
Owner

Cazka commented Oct 9, 2022

the function works perfectly when the player stands still.

Moving seems to shift the camera, which also shifts the calculated canvasPos

diepAPI.mp4
@Cazka Cazka added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Oct 9, 2022
@Cazka
Copy link
Owner Author

Cazka commented Oct 11, 2022

After some more testing, I can reassure that the issue is not in scaling.toCanvasPos().

I suspect the root cause to be here somewhere: https://github.com/Cazka/diepAPI/blob/main/src/extensions/entity_manager.ts

@Cazka Cazka mentioned this issue Oct 22, 2022
Closed
@Cazka Cazka closed this as completed Oct 22, 2022
@Cazka Cazka mentioned this issue Oct 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/fix entity manager Cazka/diepAPI
1 participant
@Cazka