Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: limit input sst size when compact for old bucket #910

Merged
merged 2 commits into from
May 23, 2023
Merged

fix: limit input sst size when compact for old bucket #910

merged 2 commits into from
May 23, 2023

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented May 22, 2023 •
edited
Loading

Related Issues

Closes #

Detailed Changes

  • Adjust logs to make it more readable.
  • trim_to_threshold respect max_input_sstable_size.

Test Plan

Manually

@jiacai2050 jiacai2050 changed the title chore: simplify compact logs fix: limit input sst size when compact for old bucket May 23, 2023
Rachelint
Rachelint approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@Rachelint Rachelint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rachelint Rachelint merged commit d628a52 into apache:main May 23, 2023
@jiacai2050 jiacai2050 deleted the chore-compact-log branch May 23, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rachelint Rachelint Rachelint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiacai2050 @Rachelint