Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KTX2/Basis sample #5

Open
lilleyse opened this issue Jul 22, 2020 · 5 comments
Open

Add KTX2/Basis sample #5

lilleyse opened this issue Jul 22, 2020 · 5 comments

Comments

@lilleyse
Copy link
Contributor

Now that KTX2/Basis support is being added to CesiumJS in CesiumGS/cesium#9040 we should add a sample that uses KTX2/Basis textures.

@YoussefV Take a look at createBatchedTextured as a reference point for the new sample. Instead of using data/wood_red.jpg the new sample would use data/wood_red.ktx2. You'll mostly be working in 3d-tiles-samples-generator.ts, createBuilding.ts, and createGltf.js.

The project is midway through changing from JavaScript to TypeScript so apologies if it's a little messy.

@YVin3D
Copy link

YVin3D commented Jul 22, 2020

searching createBatchedTextured in this repo yields no results, I can see one usage of data/wood_red.jpg here. But not sure how it relates to createBatchedTextured

@lilleyse
Copy link
Contributor Author

@YoussefV not sure why your search didn't pick it up, but you can find occurrences in 3d-tiles-samples-generator.ts

@lilleyse
Copy link
Contributor Author

Yeah sorry if my message was unclear, createBatchedTextured is a function not a file name (in case you were doing a file search)

@YVin3D
Copy link

YVin3D commented Jul 22, 2020

Yeah that's weird... Would I be replacing the .jpg or creating a new BaseColorType for a CompressedTexture?

@lilleyse
Copy link
Contributor Author

Just talked offline - but yes, the latter.

@javagl javagl transferred this issue from CesiumGS/3d-tiles-validator Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants