Skip to content

Commit 016f815

Browse files
author
Hannah
authored
Merge pull request #7693 from AnalyticalGraphicsInc/clamp-to-height-breaking-change
Remove deprecated clampToHeight function definition
2 parents 141c786 + d11fec7 commit 016f815

File tree

2 files changed

+1
-8
lines changed

2 files changed

+1
-8
lines changed

CHANGES.md

+1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ Change Log
66
##### Breaking Changes :mega:
77
* `Resource.fetchImage` now returns an `ImageBitmap` instead of `Image` when supported. This allows for decoding images while fetching using `createImageBitmap` to greatly speed up texture upload and decrease frame drops when loading models with large textures. [#7579](https://github.com/AnalyticalGraphicsInc/cesium/pull/7579)
88
* `Cesium3DTileStyle.style` now has an empty `Object` as its default value, instead of `undefined`. [#7567](https://github.com/AnalyticalGraphicsInc/cesium/issues/7567)
9+
* `Scene.clampToHeight` now takes an optional `width` argument before the `result` argument. [#7693](https://github.com/AnalyticalGraphicsInc/cesium/pull/7693)
910
* In the `Resource` class, `addQueryParameters` and `addTemplateValues` have been removed. Please use `setQueryParameters` and `setTemplateValues` instead. [#7695](https://github.com/AnalyticalGraphicsInc/cesium/issues/7695)
1011

1112
##### Deprecated :hourglass_flowing_sand:

Source/Scene/Scene.js

-8
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ define([
1414
'../Core/defaultValue',
1515
'../Core/defined',
1616
'../Core/defineProperties',
17-
'../Core/deprecationWarning',
1817
'../Core/destroyObject',
1918
'../Core/DeveloperError',
2019
'../Core/EllipsoidGeometry',
@@ -98,7 +97,6 @@ define([
9897
defaultValue,
9998
defined,
10099
defineProperties,
101-
deprecationWarning,
102100
destroyObject,
103101
DeveloperError,
104102
EllipsoidGeometry,
@@ -4233,12 +4231,6 @@ define([
42334231
}
42344232
//>>includeEnd('debug');
42354233

4236-
if (width instanceof Cartesian3) {
4237-
result = width;
4238-
width = undefined;
4239-
deprecationWarning('clampToHeight-parameter-change', 'clampToHeight now takes an optional width argument before the result argument in Cesium 1.54. The previous function definition will no longer work in 1.56.');
4240-
}
4241-
42424234
var ray = getRayForClampToHeight(this, cartesian);
42434235
var pickResult = pickFromRay(this, ray, objectsToExclude, width, true, false);
42444236
if (defined(pickResult)) {

0 commit comments

Comments
 (0)