Skip to content

Commit 1945e7a

Browse files
committed
Disable asynchronous primitives in DynamicScene
Due to #1487. We can revisit it in the future when performance is better. Since we create all the geometry up front anyway, this is a load time concern and should not become a usability issue.
1 parent b45e794 commit 1945e7a

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

Source/DynamicScene/StaticGeometryColorBatch.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ define(['../Core/Color',
6161
var geometry = this.geometry.values;
6262
if (geometry.length > 0) {
6363
primitive = new Primitive({
64-
asynchronous : true,
64+
asynchronous : false,
6565
geometryInstances : geometry,
6666
appearance : new this.appearanceType({
6767
faceForward : true,

Source/DynamicScene/StaticGeometryPerMaterialBatch.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ define(['../Core/defined',
7676
}
7777
if (geometries.length > 0) {
7878
primitive = new Primitive({
79-
asynchronous : true,
79+
asynchronous : false,
8080
geometryInstances : geometries,
8181
appearance : new this.appearanceType({
8282
material : MaterialProperty.getValue(time, this.materialProperty, this.material),

Source/DynamicScene/StaticOutlineGeometryBatch.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ define(['../Core/Color',
6161
var geometry = this.geometry.values;
6262
if (geometry.length > 0) {
6363
primitive = new Primitive({
64-
asynchronous : true,
64+
asynchronous : false,
6565
geometryInstances : geometry,
6666
appearance : new PerInstanceColorAppearance({
6767
flat : true,

0 commit comments

Comments
 (0)