Merge pull request #9085 from TerriaJS/ion-logo-fix

Cesium ion logo - support for data URL scheme

Author: Omar Shehata

CHANGES.md

@@ -5,6 +5,7 @@
 ##### Fixes :wrench:
 
 - Fixed several artifcats on mobile devices caused by using insufficient precision. [#9064](https://github.com/CesiumGS/cesium/pull/9064)
+- Fixed handling of `data:` scheme for the Cesium ion logo URL. [#9085](https://github.com/CesiumGS/cesium/pull/9085)
 
 ### 1.72 - 2020-08-03
 

CONTRIBUTORS.md

@@ -59,6 +59,7 @@ See [CONTRIBUTING.md](CONTRIBUTING.md) for details on how to contribute to Cesiu
   - [Emma Krantz](https://github.com/KeyboardSounds)
   - [Stephen Davies](https://github.com/steve9164)
   - [Rowan Winsemius](https://github.com/rowanwins)
+  - [Regina Pramesti](https://github.com/reginapramesti)
 - [EU Edge](http://euedge.com/)
   - [Ákos Maróy](https://github.com/akosmaroy)
 - [Raytheon Intelligence and Information Systems](http://www.raytheon.com/)

Source/Scene/CreditDisplay.js

@@ -516,7 +516,11 @@ function getDefaultCredit() {
 
     // When hosting in a WebView, the base URL scheme is file:// or ms-appx-web://
     // which is stripped out from the Credit's <img> tag; use the full path instead
-    if (logo.indexOf("http://") !== 0 && logo.indexOf("https://") !== 0) {
+    if (
+      logo.indexOf("http://") !== 0 &&
+      logo.indexOf("https://") !== 0 &&
+      logo.indexOf("data:") !== 0
+    ) {
       var logoUrl = new Uri(logo);
       logo = logoUrl.getPath();
     }