Skip to content

Commit 3643a8d

Browse files
committed
Remove deprecated addQueryParameters and addTemplateValues
1 parent 46cdb02 commit 3643a8d

File tree

2 files changed

+2
-31
lines changed

2 files changed

+2
-31
lines changed

CHANGES.md

+1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ Change Log
66
##### Breaking Changes :mega:
77
* `Resource.fetchImage` now returns an `ImageBitmap` instead of `Image` when supported. This allows for decoding images while fetching using `createImageBitmap` to greatly speed up texture upload and decrease frame drops when loading models with large textures. [#7579](https://github.com/AnalyticalGraphicsInc/cesium/pull/7579)
88
* `Cesium3DTileStyle.style` now has an empty `Object` as its default value, instead of `undefined`. [#7567](https://github.com/AnalyticalGraphicsInc/cesium/issues/7567)
9+
* In the `Resource` class, `addQueryParameters` and `addTemplateValues` have been removed. Please use `setQueryParameters` and `setTemplateValues` instead.
910

1011
##### Deprecated :hourglass_flowing_sand:
1112
* `Resource.fetchImage` now takes an options object. Use `resource.fetchImage({ preferBlob: true })` instead of `resource.fetchImage(true)`. The previous function definition will no longer work in 1.57. [#7579](https://github.com/AnalyticalGraphicsInc/cesium/pull/7579)

Source/Core/Resource.js

+1-31
Original file line numberDiff line numberDiff line change
@@ -601,21 +601,6 @@ define([
601601
}
602602
};
603603

604-
/**
605-
* Combines the specified object and the existing query parameters. This allows you to add many parameters at once,
606-
* as opposed to adding them one at a time to the queryParameters property. If a value is already set, it will be replaced with the new value.
607-
*
608-
* @param {Object} params The query parameters
609-
* @param {Boolean} [useAsDefault=false] If true the params will be used as the default values, so they will only be set if they are undefined.
610-
*
611-
* @deprecated
612-
*/
613-
Resource.prototype.addQueryParameters = function(params, useAsDefault) {
614-
deprecationWarning('Resource.addQueryParameters', 'addQueryParameters has been deprecated and will be removed 1.45. Use setQueryParameters or appendQueryParameters instead.');
615-
616-
return this.setQueryParameters(params, useAsDefault);
617-
};
618-
619604
/**
620605
* Combines the specified object and the existing query parameters. This allows you to add many parameters at once,
621606
* as opposed to adding them one at a time to the queryParameters property.
@@ -641,21 +626,6 @@ define([
641626
}
642627
};
643628

644-
/**
645-
* Combines the specified object and the existing template values. This allows you to add many values at once,
646-
* as opposed to adding them one at a time to the templateValues property. If a value is already set, it will become an array and the new value will be appended.
647-
*
648-
* @param {Object} template The template values
649-
* @param {Boolean} [useAsDefault=false] If true the values will be used as the default values, so they will only be set if they are undefined.
650-
*
651-
* @deprecated
652-
*/
653-
Resource.prototype.addTemplateValues = function(template, useAsDefault) {
654-
deprecationWarning('Resource.addTemplateValues', 'addTemplateValues has been deprecated and will be removed 1.45. Use setTemplateValues.');
655-
656-
return this.setTemplateValues(template, useAsDefault);
657-
};
658-
659629
/**
660630
* Returns a resource relative to the current instance. All properties remain the same as the current instance unless overridden in options.
661631
*
@@ -899,7 +869,7 @@ define([
899869
*/
900870
Resource.prototype.fetchImage = function (options) {
901871
if (typeof options === 'boolean') {
902-
deprecationWarning('fetchImage-parameter-change', 'fetchImage now takes an options object in CesiumJS 1.56. Use resource.fetchImage({ preferBlob: true }) instead of resource.fetchImage(true).');
872+
deprecationWarning('fetchImage-parameter-change', 'fetchImage now takes an options object in CesiumJS 1.57. Use resource.fetchImage({ preferBlob: true }) instead of resource.fetchImage(true).');
903873
options = {
904874
preferBlob : options
905875
};

0 commit comments

Comments
 (0)