Skip to content

Commit 4edd9b5

Browse files
author
hpinkos
committed
cleanup
1 parent de71dc0 commit 4edd9b5

File tree

2 files changed

+47
-1
lines changed

2 files changed

+47
-1
lines changed

Apps/Sandcastle/gallery/Polygon.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@
111111
});
112112

113113
var cyanPolygon = viewer.entities.add({
114-
name : 'Orange polygon with per-position heights and outline',
114+
name : 'Cyan vertical polygon with per-position heights and outline',
115115
polygon : {
116116
hierarchy : Cesium.Cartesian3.fromDegreesArrayHeights([
117117
-90.0, 41.0, 0.0,

Specs/DataSources/PolygonGeometryUpdaterSpec.js

+46
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ defineSuite([
66
'Core/GeometryOffsetAttribute',
77
'Core/JulianDate',
88
'Core/Math',
9+
'Core/CoplanarPolygonGeometry',
10+
'Core/CoplanarPolygonOutlineGeometry',
11+
'Core/PolygonGeometry',
12+
'Core/PolygonOutlineGeometry',
913
'Core/PolygonHierarchy',
1014
'Core/TimeIntervalCollection',
1115
'DataSources/ConstantProperty',
@@ -29,6 +33,10 @@ defineSuite([
2933
GeometryOffsetAttribute,
3034
JulianDate,
3135
CesiumMath,
36+
CoplanarPolygonGeometry,
37+
CoplanarPolygonOutlineGeometry,
38+
PolygonGeometry,
39+
PolygonOutlineGeometry,
3240
PolygonHierarchy,
3341
TimeIntervalCollection,
3442
ConstantProperty,
@@ -78,6 +86,19 @@ defineSuite([
7886
return entity;
7987
}
8088

89+
function createVerticalPolygon() {
90+
var polygon = new PolygonGraphics();
91+
polygon.hierarchy = new ConstantProperty(new PolygonHierarchy(Cartesian3.fromDegreesArrayHeights([
92+
-1.0, 1.0, 0.0,
93+
-2.0, 1.0, 0.0,
94+
-2.0, 1.0, 0.0
95+
])));
96+
polygon.perPositionHeight = true;
97+
var entity = new Entity();
98+
entity.polygon = polygon;
99+
return entity;
100+
}
101+
81102
function createDynamicPolygon() {
82103
var entity = createBasicPolygon();
83104
entity.polygon.extrudedHeight = createDynamicProperty(2);
@@ -231,6 +252,7 @@ defineSuite([
231252
var geometry;
232253
instance = updater.createFillGeometryInstance(time);
233254
geometry = instance.geometry;
255+
expect(geometry).toBeInstanceOf(PolygonGeometry);
234256
expect(geometry._stRotation).toEqual(options.stRotation);
235257
expect(geometry._height).toEqual(options.height);
236258
expect(geometry._granularity).toEqual(options.granularity);
@@ -241,13 +263,37 @@ defineSuite([
241263

242264
instance = updater.createOutlineGeometryInstance(time);
243265
geometry = instance.geometry;
266+
expect(geometry).toBeInstanceOf(PolygonOutlineGeometry);
244267
expect(geometry._height).toEqual(options.height);
245268
expect(geometry._granularity).toEqual(options.granularity);
246269
expect(geometry._extrudedHeight).toEqual(options.extrudedHeight);
247270
expect(geometry._perPositionHeight).toEqual(options.perPositionHeight);
248271
expect(geometry._offsetAttribute).toBeUndefined();
249272
});
250273

274+
it('Creates coplanar polygon', function() {
275+
var stRotation = 12;
276+
277+
var entity = createVerticalPolygon();
278+
279+
var polygon = entity.polygon;
280+
polygon.outline = true;
281+
polygon.stRotation = new ConstantProperty(stRotation);
282+
283+
var updater = new PolygonGeometryUpdater(entity, scene);
284+
285+
var instance;
286+
var geometry;
287+
instance = updater.createFillGeometryInstance(time);
288+
geometry = instance.geometry;
289+
expect(geometry).toBeInstanceOf(CoplanarPolygonGeometry);
290+
expect(geometry._stRotation).toEqual(stRotation);
291+
292+
instance = updater.createOutlineGeometryInstance(time);
293+
geometry = instance.geometry;
294+
expect(geometry).toBeInstanceOf(CoplanarPolygonOutlineGeometry);
295+
});
296+
251297
it('Checks that a polygon with per position heights isn\'t on terrain', function() {
252298
var entity = createBasicPolygon();
253299
entity.polygon.height = undefined;

0 commit comments

Comments
 (0)