Merge pull request #9017 from vipulgusain/fix_return_SampledPositionProperty_removeSample

fixed the return statetment as SampledProperty removeSample is return…

Author: Hannah

CHANGES.md

@@ -10,6 +10,7 @@
 - Fixed wall rendering when underground [#9041](https://github.com/CesiumGS/cesium/pull/9041)
 - Fixed issue where a side of the wall was missing if the first position and the last position were equal [#9044](https://github.com/CesiumGS/cesium/pull/9044)
 - Fixed `translucencyByDistance` for label outline color [#9003](https://github.com/CesiumGS/cesium/pull/9003)
+- Fixed return value for `SampledPositionProperty.removeSample` [#9017](https://github.com/CesiumGS/cesium/pull/9017)
 
 ### 1.71 - 2020-07-01
 

CONTRIBUTORS.md

@@ -272,3 +272,4 @@ See [CONTRIBUTING.md](CONTRIBUTING.md) for details on how to contribute to Cesiu
 - [John Remsberg](https://github.com/easternmotors)
 - [Bao Thien Tran](https://github.com/baothientran)
 - [Yonatan Kra](https://github.com/yonatankra)
+- [Gusain Vipul](https://github.com/vipulgusain)

Source/DataSources/SampledPositionProperty.js

@@ -295,7 +295,7 @@ SampledPositionProperty.prototype.addSamplesPackedArray = function (
  * @returns {Boolean} <code>true</code> if a sample at time was removed, <code>false</code> otherwise.
  */
 SampledPositionProperty.prototype.removeSample = function (time) {
-  this._property.removeSample(time);
+  return this._property.removeSample(time);
 };
 
 /**

Specs/DataSources/SampledPositionPropertySpec.js

@@ -193,11 +193,15 @@ describe("DataSources/SampledPositionProperty", function () {
     var listener = jasmine.createSpy("listener");
     property.definitionChanged.addEventListener(listener);
 
-    property.removeSample(times[1]);
+    var result = property.removeSample(new JulianDate(4, 0));
+    expect(result).toEqual(false);
+
+    result = property.removeSample(times[1]);
 
     expect(listener).toHaveBeenCalledWith(property);
 
     expect(property.getValue(times[0])).toEqual(values[0]);
+    expect(result).toEqual(true);
     // removing the sample at times[1] causes the property to interpolate
     expect(property.getValue(times[1])).toEqual(new Cartesian3(8, 9, 10));
     expect(property.getValue(times[2])).toEqual(values[2]);

Specs/DataSources/SampledPropertySpec.js

@@ -125,10 +125,13 @@ describe("DataSources/SampledProperty", function () {
     var listener = jasmine.createSpy("listener");
     property.definitionChanged.addEventListener(listener);
 
-    property.removeSample(times[1]);
+    var result = property.removeSample(new JulianDate(4, 0));
+    expect(result).toEqual(false);
 
-    expect(listener).toHaveBeenCalledWith(property);
+    result = property.removeSample(times[1]);
 
+    expect(listener).toHaveBeenCalledWith(property);
+    expect(result).toEqual(true);
     expect(property._times.length).toEqual(2);
     expect(property._values.length).toEqual(2);