Skip to content

Commit c3f5a51

Browse files
authored
Merge pull request #6681 from AnalyticalGraphicsInc/more-orientations
Missed a constructor in #6632.
2 parents d321899 + beab213 commit c3f5a51

File tree

4 files changed

+9
-3
lines changed

4 files changed

+9
-3
lines changed

Source/Scene/ClassificationModel.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ define([
8888
///////////////////////////////////////////////////////////////////////////
8989

9090
/**
91-
* A 3D model for classifying other 3D assets based on glTF, the runtime asset format for WebGL, OpenGL ES, and OpenGL.
91+
* A 3D model for classifying other 3D assets based on glTF, the runtime 3D asset format.
9292
* This is a special case when a model of a 3D tileset becomes a classifier when setting {@link Cesium3DTileset#classificationType}.
9393
*
9494
* @alias ClassificationModel

Source/Scene/Instanced3DModel3DTileContent.js

+3
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ define([
2121
'../Core/Transforms',
2222
'../Core/TranslationRotationScale',
2323
'../Renderer/Pass',
24+
'./Axis',
2425
'./Cesium3DTileBatchTable',
2526
'./Cesium3DTileFeature',
2627
'./Cesium3DTileFeatureTable',
@@ -48,6 +49,7 @@ define([
4849
Transforms,
4950
TranslationRotationScale,
5051
Pass,
52+
Axis,
5153
Cesium3DTileBatchTable,
5254
Cesium3DTileFeature,
5355
Cesium3DTileFeatureTable,
@@ -281,6 +283,7 @@ define([
281283
basePath : undefined,
282284
incrementallyLoadTextures : false,
283285
upAxis : content._tileset._gltfUpAxis,
286+
forwardAxis : Axis.X,
284287
opaquePass : Pass.CESIUM_3D_TILE, // Draw opaque portions during the 3D Tiles pass
285288
pickIdLoaded : getPickIdCallback(content)
286289
};

Source/Scene/ModelInstanceCollection.js

+2
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,7 @@ define([
152152
this._asynchronous = options.asynchronous;
153153
this._incrementallyLoadTextures = options.incrementallyLoadTextures;
154154
this._upAxis = options.upAxis; // Undocumented option
155+
this._forwardAxis = options.forwardAxis; // Undocumented option
155156

156157
this.shadows = defaultValue(options.shadows, ShadowMode.ENABLED);
157158
this._shadows = this.shadows;
@@ -569,6 +570,7 @@ define([
569570
allowPicking : allowPicking,
570571
incrementallyLoadTextures : collection._incrementallyLoadTextures,
571572
upAxis : collection._upAxis,
573+
forwardAxis : collection._forwardAxis,
572574
precreatedAttributes : undefined,
573575
vertexShaderLoaded : undefined,
574576
fragmentShaderLoaded : undefined,

Specs/Scene/ModelSpec.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -2273,7 +2273,6 @@ defineSuite([
22732273

22742274
function checkVertexColors(model) {
22752275
model.zoomTo();
2276-
scene.camera.rotateRight(CesiumMath.PI_OVER_TWO);
22772276
scene.camera.moveUp(0.1);
22782277
// Red
22792278
scene.camera.moveLeft(0.5);
@@ -2318,7 +2317,9 @@ defineSuite([
23182317
});
23192318

23202319
it('loads a glTF 2.0 with vertex colors', function() {
2321-
return loadModel(vertexColorTestUrl).then(function(m) {
2320+
return loadModel(vertexColorTestUrl, {
2321+
forwardAxis : Axis.X
2322+
}).then(function(m) {
23222323
m.show = true;
23232324
checkVertexColors(m);
23242325
primitives.remove(m);

0 commit comments

Comments
 (0)