Skip to content

Commit c5abf0d

Browse files
authored
Merge pull request #9387 from CesiumGS/remove-deprecated-snippets
Remove deprecated Cesium3DTileset.url getter, quadratic easing function typos
2 parents 6da0cc8 + 5143ed5 commit c5abf0d

File tree

4 files changed

+10
-73
lines changed

4 files changed

+10
-73
lines changed

CHANGES.md

+9-2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,13 @@
22

33
### 1.79 - 2021-03-01
44

5+
##### Breaking Changes :mega:
6+
7+
- Removed `Cesium3DTileset.url`, which was deprecated in CesiumJS 1.78. Use `Cesium3DTileset.resource.url` to retrieve the url value.
8+
- Removed `EasingFunction.QUADRACTIC_IN`, which was deprecated in CesiumJS 1.77. Use `EasingFunction.QUADRATIC_IN`.
9+
- Removed `EasingFunction.QUADRACTIC_OUT`, which was deprecated in CesiumJS 1.77. Use `EasingFunction.QUADRATIC_OUT`.
10+
- Removed `EasingFunction.QUADRACTIC_IN_OUT`, which was deprecated in CesiumJS 1.77. Use `EasingFunction.QUADRATIC_IN_OUT`.
11+
512
##### Fixes :wrench:
613

714
- Fixed an issue that prevented use of the full CesiumJS zip release package in a Node.js application.
@@ -75,8 +82,8 @@
7582

7683
##### Breaking Changes :mega:
7784

78-
- Removed `MapboxApi`, which was deprecated in v1.72. Pass your access token directly to the `MapboxImageryProvider` or `MapboxStyleImageryProvider` constructors.
79-
- Removed `BingMapsApi`, which was deprecated in v1.72. Pass your access key directly to the `BingMapsImageryProvider` or `BingMapsGeocoderService` constructors.
85+
- Removed `MapboxApi`, which was deprecated in CesiumJS 1.72. Pass your access token directly to the `MapboxImageryProvider` or `MapboxStyleImageryProvider` constructors.
86+
- Removed `BingMapsApi`, which was deprecated in CesiumJS 1.72. Pass your access key directly to the `BingMapsImageryProvider` or `BingMapsGeocoderService` constructors.
8087

8188
##### Additions :tada:
8289

CONTRIBUTORS.md

+1
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,7 @@ See [CONTRIBUTING.md](CONTRIBUTING.md) for details on how to contribute to Cesiu
150150
- [Erixen Cruz](https://github.com/ErixenCruz)
151151
- [Dzung Nguyen](https://github.com/dzungpng)
152152
- [Nithin Pranesh](https://github.com/nithinp7)
153+
- [Alexander Gallegos](https://github.com/argallegos)
153154
- [Northrop Grumman](http://www.northropgrumman.com)
154155
- [Joseph Stein](https://github.com/nahgrin)
155156
- [EOX IT Services GmbH](https://eox.at)

Source/Core/EasingFunction.js

-52
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import Tween from "../ThirdParty/Tween.js";
2-
import deprecationWarning from "./deprecationWarning.js";
32

43
/**
54
* Easing functions for use with TweenCollection. These function are from
@@ -238,57 +237,6 @@ var EasingFunction = {
238237
BOUNCE_IN_OUT: Tween.Easing.Bounce.InOut,
239238
};
240239

241-
Object.defineProperties(EasingFunction, {
242-
/**
243-
* Quadratic in.
244-
* @memberof EasingFunction
245-
* @type {EasingFunction.Callback}
246-
* @constant
247-
* @deprecated This enum has been deprecated and will be removed in Cesium 1.79. Use {@link EasingFunction.QUADRATIC_IN} instead.
248-
*/
249-
QUADRACTIC_IN: {
250-
get: function () {
251-
deprecationWarning(
252-
"QUADRACTIC_IN",
253-
"QUADRACTIC_IN is deprecated and will be removed in Cesium 1.79. Use QUADRATIC_IN instead."
254-
);
255-
return Tween.Easing.Quadratic.In;
256-
},
257-
},
258-
/**
259-
* Quadratic out.
260-
* @memberof EasingFunction
261-
* @type {EasingFunction.Callback}
262-
* @constant
263-
* @deprecated This enum has been deprecated and will be removed in Cesium 1.79. Use {@link EasingFunction.QUADRATIC_OUT} instead.
264-
*/
265-
QUADRACTIC_OUT: {
266-
get: function () {
267-
deprecationWarning(
268-
"QUADRACTIC_OUT",
269-
"QUADRACTIC_OUT is deprecated and will be removed in Cesium 1.79. Use QUADRATIC_OUT instead."
270-
);
271-
return Tween.Easing.Quadratic.Out;
272-
},
273-
},
274-
/**
275-
* Quadratic in then out.
276-
* @memberof EasingFunction
277-
* @type {EasingFunction.Callback}
278-
* @constant
279-
* @deprecated This enum has been deprecated and will be removed in Cesium 1.79. Use {@link EasingFunction.QUADRATIC_IN_OUT} instead.
280-
*/
281-
QUADRACTIC_IN_OUT: {
282-
get: function () {
283-
deprecationWarning(
284-
"QUADRACTIC_IN_OUT",
285-
"QUADRACTIC_IN_OUT is deprecated and will be removed in Cesium 1.79. Use QUADRATIC_IN_OUT instead."
286-
);
287-
return Tween.Easing.Quadratic.InOut;
288-
},
289-
},
290-
});
291-
292240
/**
293241
* Function interface for implementing a custom easing function.
294242
* @callback EasingFunction.Callback

Source/Scene/Cesium3DTileset.js

-19
Original file line numberDiff line numberDiff line change
@@ -1165,25 +1165,6 @@ Object.defineProperties(Cesium3DTileset.prototype, {
11651165
},
11661166
},
11671167

1168-
/**
1169-
* The url to a tileset JSON file.
1170-
*
1171-
* @memberof Cesium3DTileset.prototype
1172-
*
1173-
* @type {String}
1174-
* @readonly
1175-
* @deprecated
1176-
*/
1177-
url: {
1178-
get: function () {
1179-
deprecationWarning(
1180-
"Cesium3DTileset.url",
1181-
"Cesium3DTileset.url has been deprecated and will be removed in CesiumJS 1.79. Instead, use Cesium3DTileset.resource.url to retrieve the url value."
1182-
);
1183-
return this._url;
1184-
},
1185-
},
1186-
11871168
/**
11881169
* The resource used to fetch the tileset JSON file
11891170
*

0 commit comments

Comments
 (0)