Skip to content

Commit c6a5bd0

Browse files
committed
Upgrade gltf-pipeline and fix test
1 parent cceb56c commit c6a5bd0

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

Source/ThirdParty/GltfPipeline/updateVersion.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -853,7 +853,8 @@ define([
853853
(!defined(node.translation) || Cartesian3.fromArray(node.translation).equals(Cartesian3.ZERO)) &&
854854
(!defined(node.scale) || Cartesian3.fromArray(node.scale).equals(new Cartesian3(1.0, 1.0, 1.0))) &&
855855
(!defined(node.rotation) || Cartesian4.fromArray(node.rotation).equals(new Cartesian4(0.0, 0.0, 0.0, 1.0))) &&
856-
(!defined(node.matrix) || Matrix4.fromColumnMajorArray(node.matrix).equals(Matrix4.IDENTITY));
856+
(!defined(node.matrix) || Matrix4.fromColumnMajorArray(node.matrix).equals(Matrix4.IDENTITY)) &&
857+
!defined(node.extensions && !defined(node.extras));
857858
}
858859

859860
function deleteNode(gltf, nodeId) {

Specs/Scene/ModelSpec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -2080,7 +2080,7 @@ defineSuite([
20802080
expect(scene).toRender([0, 0, 0, 255]);
20812081
m.show = true;
20822082
m.zoomTo();
2083-
expect(scene).toRender([51, 51, 51, 255]); // Cesium has minimum lighting
2083+
expect(scene).toRender([0, 0, 0, 255]);
20842084
m.show = false;
20852085

20862086
primitives.remove(m);

0 commit comments

Comments
 (0)