Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera will go througth 3dtiles in zoom #11107

Closed
jiangheng90 opened this issue Feb 23, 2023 · 1 comment
Closed

Camera will go througth 3dtiles in zoom #11107

jiangheng90 opened this issue Feb 23, 2023 · 1 comment

Comments

@jiangheng90
Copy link
Contributor

jiangheng90 commented Feb 23, 2023

The issuse is from #11062 , this morning I found camera will go throght buildings when camera is above 50m
I think this may comes from

  const inertiaMovementApproachingGround = Math.abs(height) < 50;

  const needPickGlobe = inertiaMovement
    ? inertiaMovementApproachingGround
    : height < controller._minimumPickingTerrainHeight;
  if (needPickGlobe) {
    intersection = pickGlobe(controller, windowPosition, zoomCVIntersection);
  }

this condition will still fail when camera go through 3dtiles in a relative high altitude. so I think use the distance in previouse maybe more reliable.
fixed in pr #11108

@jiangheng90 jiangheng90 changed the title camera will go througth 3dtiles in zoom Camera will go througth 3dtiles in zoom Feb 23, 2023
@ggetz
Copy link
Contributor

ggetz commented Feb 28, 2023

Fixed in #11108

@ggetz ggetz closed this as completed Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants