Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to zoom in after setting the relative height of vertical exaggeration #11974

Open
syzdev opened this issue May 10, 2024 · 3 comments
Open

Comments

@syzdev
Copy link
Contributor

syzdev commented May 10, 2024

What happened?

This issue comes from #11936 , I think this is another issue, so I created a new one. If the model is in the air, the reference height can be set to the center of the model, but the camera cannot zoom in.

sandcastle

GIF1

Reproduction steps

1.Exaggeration -> 5
2.Relative Height -> 9000
3.Mouse wheel -> zoom in
...

Sandcastle example

sandcastle

Environment

Browser: Google Chrome Version 124.0.6367.119 (Official Build) (64-bit)
CesiumJS Version: 1.117
Operating System: Windows 11 22H2

@ggetz
Copy link
Contributor

ggetz commented May 10, 2024

@jjhembd Could you please triage this issue?

@jjhembd
Copy link
Contributor

jjhembd commented May 13, 2024

Thanks for the report @syzdev! I can reproduce the problem on my machine, and it does look like a separate issue.

I can zoom all the way in if I turn off camera collision checks, as in this updated Sandcastle.

scene.screenSpaceCameraController.enableCollisionDetection = false;

It looks like ScreenSpaceCameraController is missing a check of scene.verticalExaggerationRelativeHeight somewhere, perhaps in the calculation of minHeight in the handleZoom method.

@ggetz
Copy link
Contributor

ggetz commented Sep 3, 2024

Looking at #12141, it appears the bounding volume is not properly accounting for exaggeration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants