Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate Playwright testing during CI #12355

Open
jjspace opened this issue Dec 2, 2024 · 0 comments
Open

Automate Playwright testing during CI #12355

jjspace opened this issue Dec 2, 2024 · 0 comments

Comments

@jjspace
Copy link
Contributor

jjspace commented Dec 2, 2024

One of the slowest parts of our current release process is running our end to end tests through Playwright. It's also very late in the process to catch any serious errors that could prevent or hold up doing the release. Playwright has fairly robust docs for how to use it in CI but we currently don't so I'd like to start the discussion around why and whether we can enable it.

  1. Why didn't we set it up with CI in the first place?
  2. Why are we not including snapshots in the repo itself? Is it a repo space issue?
    • I suspect one reason for this is the difference in rendering between systems. If that's the case I would still assume the large majority of our tests will look identical on all systems and we should set up a system to mark the ones that don't.
  3. Why are we only running the e2e tests on releases? Is it just because they're too slow to run every pr? (CI might help reduce the need to run them locally)

This issue also closely couples with #12281 because we will need to be much more precise with certain tests (like particles) so they actually are perfectly reproducible every time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant