You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
One of the slowest parts of our current release process is running our end to end tests through Playwright. It's also very late in the process to catch any serious errors that could prevent or hold up doing the release. Playwright has fairly robust docs for how to use it in CI but we currently don't so I'd like to start the discussion around why and whether we can enable it.
Why didn't we set it up with CI in the first place?
Looking at the initial implementation PR it just wasn't priority at that time. I'd argue it maybe should be at this point.
Why are we not including snapshots in the repo itself? Is it a repo space issue?
I suspect one reason for this is the difference in rendering between systems. If that's the case I would still assume the large majority of our tests will look identical on all systems and we should set up a system to mark the ones that don't.
Why are we only running the e2e tests on releases? Is it just because they're too slow to run every pr? (CI might help reduce the need to run them locally)
This issue also closely couples with #12281 because we will need to be much more precise with certain tests (like particles) so they actually are perfectly reproducible every time.
The text was updated successfully, but these errors were encountered:
One of the slowest parts of our current release process is running our end to end tests through Playwright. It's also very late in the process to catch any serious errors that could prevent or hold up doing the release. Playwright has fairly robust docs for how to use it in CI but we currently don't so I'd like to start the discussion around why and whether we can enable it.
This issue also closely couples with #12281 because we will need to be much more precise with certain tests (like particles) so they actually are perfectly reproducible every time.
The text was updated successfully, but these errors were encountered: