Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orbit line morph artifact #1593

Closed
pjcozzi opened this issue Mar 31, 2014 · 2 comments
Closed

Orbit line morph artifact #1593

pjcozzi opened this issue Mar 31, 2014 · 2 comments
Assignees

Comments

@pjcozzi
Copy link
Contributor

pjcozzi commented Mar 31, 2014

  • Open the CZML Sandcastle example.
  • Pause it (useful, but not necessary).
  • Morph to 2D. Take note of the yellow orbit line.
  • Morph to 3D or CV. When the morph starts, the orbit line shrinks and grows.

Before morph to 3D/CV:

image

Right when morph starts:

image

This has been around for a while AFAIR, well before b26. I'm not sure yet what we can reasonably do about this.

@mramato
Copy link
Contributor

mramato commented Oct 14, 2015

I believe the problem here is that the PathVisualizer switches inertially visualized paths to fixed paths the moment SceneMode is anything by Scene3D. The correct way to address this would be to interpolate between the inertially computed path and the fixed computed path when morphing. Since we can't interpolate the transform matrix, this would involve generating both fixed and inertial paths and then interpolating between the computed positions. It wil be CPU intensive and I'm not sure it's worth it, but if we really want to fix this, that's what we'll have to do.

@bagnell
Copy link
Contributor

bagnell commented May 24, 2016

I think this was fixed by #3768. I can't reproduce this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants