Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSDoc Issues #1859

Closed
4 of 5 tasks
pjcozzi opened this issue Jun 24, 2014 · 4 comments
Closed
4 of 5 tasks

JSDoc Issues #1859

pjcozzi opened this issue Jun 24, 2014 · 4 comments
Labels
category - doc category - tooling good first issue An opportunity for first time contributors

Comments

@pjcozzi
Copy link
Contributor

pjcozzi commented Jun 24, 2014

Part of #1684 for post 1.0. We should consider submitting issues for each to JSDoc.

  • After Issue1434 #1729, array types do not create links to the element type. Not investigated yet.
  • Modules containing functions do not show the function signature. Example binarySearch. This is because it can't tell whether the module is a function, or an object (example WindingOrder) This may be fixable in our template.
  • Functions still must be declared as var Foo = function() instead of function Foo(). I assume this is a parsing problem in JSDoc that we cannot fix on our end.
  • @link inside @default does not create a link in the documentation, e.g., @default {@link Cartesian3.ZERO} just turns into Cartesian3.ZERO. @link tags elsewhere appear to work.
  • Fix jsDoc to allow @exception tag on ECMAScript 5 properties... #832 - @exception for ECMAScript 5 properties.
@pjcozzi
Copy link
Contributor Author

pjcozzi commented Nov 3, 2016

@mramato any update if these are still relevant with the latest version?

@mramato
Copy link
Contributor

mramato commented Nov 3, 2016

I'm pretty sure they are both still relevant, but we should actually try and see. I'll do that when I get a chance.

@pjcozzi pjcozzi added the good first issue An opportunity for first time contributors label Jan 2, 2017
@bampakoa
Copy link
Contributor

@pjcozzi @mramato I can confirm that both

are working with the latest version.

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Mar 12, 2017

Thanks for the research, @bampakoa. @mramato if/when we are on the latest version, can you please close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category - doc category - tooling good first issue An opportunity for first time contributors
Projects
None yet
Development

No branches or pull requests

5 participants