Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material documentation #1920

Closed
emackey opened this issue Jul 15, 2014 · 5 comments · Fixed by #1973
Closed

Material documentation #1920

emackey opened this issue Jul 15, 2014 · 5 comments · Fixed by #1973

Comments

@emackey
Copy link
Contributor

emackey commented Jul 15, 2014

Some fields are undocumented.

Material.prototype.isTranslucent
Material.DefaultImageId
Material.DefaultCubeMapId

Material.ColorType
Material.ImageType
Material.DiffuseMapType
Material.AlphaMapType
Material.SpecularMapType
Material.EmissionMapType
Material.BumpMapType
Material.NormalMapType
Material.GridType
Material.StripeType
Material.CheckerboardType
Material.DotType
Material.WaterType
Material.RimLightingType
Material.FadeType
Material.PolylineArrowType
Material.PolylineGlowType
Material.PolylineOutlineType
@emackey emackey added the doc label Jul 15, 2014
@mramato mramato added the 1.0 label Jul 15, 2014
@mramato
Copy link
Contributor

mramato commented Jul 17, 2014

Also, these types are treated as constants but do not follow the uppercase/underscore convention; i.e. COLOR_TYPE instead of ColorType.

@mramato
Copy link
Contributor

mramato commented Jul 25, 2014

Also, should we create a MaterialType enum to contain all of the types instead of having them on Material itself?

As soon as we get an answer, someone can actually work on this.

@pjcozzi
Copy link
Contributor

pjcozzi commented Jul 25, 2014

The constants are documented-ish at the top of Material. I would be fine with just dropping the *Type constants in place of strings since I always find them confusing anyway (#1185, #640).

@emackey
Copy link
Contributor Author

emackey commented Jul 25, 2014

I don't have a strong opinion here, but I'll point out that using documented enums would allow a Sandcastle user to double-click the material type and get the direct link to docs on the available uniforms for that particular type (which is how I discovered this bug; I attempted to double-click a type I was curious about).

I don't think the Color class is broken up with a separate enum class for all the named colors, perhaps we can keep Material as a single class as well?

@pjcozzi
Copy link
Contributor

pjcozzi commented Jul 25, 2014

I'd rather not require the user to have to interact with yet another type so that the Sandcastle feature works. Just leave them or drop them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants