-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Material documentation #1920
Comments
Also, these types are treated as constants but do not follow the uppercase/underscore convention; i.e. COLOR_TYPE instead of ColorType. |
Also, should we create a As soon as we get an answer, someone can actually work on this. |
The constants are documented-ish at the top of Material. I would be fine with just dropping the |
I don't have a strong opinion here, but I'll point out that using documented enums would allow a Sandcastle user to double-click the material type and get the direct link to docs on the available uniforms for that particular type (which is how I discovered this bug; I attempted to double-click a type I was curious about). I don't think the Color class is broken up with a separate enum class for all the named colors, perhaps we can keep Material as a single class as well? |
I'd rather not require the user to have to interact with yet another type so that the Sandcastle feature works. Just leave them or drop them. |
Some fields are undocumented.
The text was updated successfully, but these errors were encountered: