Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reprojected ImageryLayers cause a crash if show is toggled before the tiles have loaded #3832

Closed
denverpierce opened this issue Apr 12, 2016 · 8 comments

Comments

@denverpierce
Copy link
Contributor

image

To reproduce, run the below in sandcastle 1.20, and zoom/pan until you get an uncached tile:

https://gist.github.com/denverpierce/72179dce5bbfd850df3c356f9df07ba6

This only happens with layers that require reprojection from webmercator and retrieving tiles from a 'slow' server and toggling the ImageryLayer's show property quickly.

@hpinkos
Copy link
Contributor

hpinkos commented Apr 12, 2016

Thanks for the code sample @denverpierce!
I can confirm that this crash happens in 1.20 but it looks like it has already been fixed in master.
If you are still seeing this problem in 1.21, please reopen this issue. Thanks again!

@hpinkos hpinkos closed this as completed Apr 12, 2016
@denverpierce
Copy link
Contributor Author

Still happens in 1.21 7fc81f7 consistently.

image

I mainly get it when loading tiles that are not in the browser cache, and it's very easy to trigger when loading tiles from a server that is particularly slow.

P.S. gist loading is great.

@denverpierce
Copy link
Contributor Author

Not sure if I can reopen this, but here's a gif of it in 1.21:

ss

@hpinkos hpinkos reopened this Apr 12, 2016
@hpinkos
Copy link
Contributor

hpinkos commented Apr 12, 2016

Thanks @denverpierce. I didn't let it run for long enough. It insta-crashed for me in 1.20 but not in master. I can confirm this is a still a problem though, so I re-opened the issue.

@hpinkos
Copy link
Contributor

hpinkos commented Sep 9, 2016

@denverpierce are you able to still reproduce this one? I think we may have actually fixed it this time. I let it run for like 2 or 3 minutes and it didn't crash for me. In 1.21 it crashed in like 20 seconds

@mramato
Copy link
Contributor

mramato commented Sep 9, 2016

@hpinkos that's caused I fixed this in #4258 😄 Didn't realize this bug existed since it is a dupe of #4083

@mramato mramato closed this as completed Sep 9, 2016
@mramato
Copy link
Contributor

mramato commented Sep 9, 2016

Of @denverpierce if you are still having an issue, please re-open this.

@denverpierce
Copy link
Contributor Author

Yeah I haven't checked it, but fairly certain its the same as #4083

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants