Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated visualizer scene constructor parameter #4385

Closed
bagnell opened this issue Sep 29, 2016 · 4 comments
Closed

Remove deprecated visualizer scene constructor parameter #4385

bagnell opened this issue Sep 29, 2016 · 4 comments

Comments

@bagnell
Copy link
Contributor

bagnell commented Sep 29, 2016

Remove BillboardVisualizer, LabelVisualizer and PointVisualizer scene constructor argument.
@pjcozzi
Copy link
Contributor

pjcozzi commented Sep 29, 2016

Labeled remove in 1.2.7; I don't think this will impact many users.

@erikmaarten erikmaarten mentioned this issue Oct 24, 2016
Merged
@erikmaarten
Copy link
Contributor

Pull request merged, I think this can be closed.

@mramato mramato closed this as completed Oct 26, 2016
@mramato
Copy link
Contributor

mramato commented Oct 26, 2016

Thanks. As an FYI, if you put "Fixes #XXXX" in your PR descriptions, then issues will automatically close when they get merged.

@erikmaarten
Copy link
Contributor

@mramato Thanks Matt, I had a vague feeling I was missing something that could make it automatic... That's exactly what I need 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pjcozzi @bagnell @mramato @erikmaarten