Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple problems with Pick position demo in Sandcastle #4572

Closed
mramato opened this issue Nov 1, 2016 · 1 comment
Closed

Multiple problems with Pick position demo in Sandcastle #4572

mramato opened this issue Nov 1, 2016 · 1 comment
Labels
good first issue An opportunity for first time contributors type - bug

Comments

@mramato
Copy link
Contributor

mramato commented Nov 1, 2016

The Pick position part of the overall picking example (http://localhost:8080/Apps/Sandcastle/index.html?src=Picking.html&label=All) has several problems.

  1. Switching to 2D just causes a bunch of errors to the console because 2D isn't supported. We should probably more gracefully handle this case in the demo.
  2. CV silently fails. Is pick position supposed to be supported for CV?
@pjcozzi pjcozzi added the good first issue An opportunity for first time contributors label Dec 20, 2016
@pjcozzi pjcozzi mentioned this issue Dec 20, 2016
Closed
@rahwang rahwang mentioned this issue Jan 20, 2017
Merged
@pjcozzi
Copy link
Contributor

pjcozzi commented Jan 21, 2017

#4892 patched the Sandcastle example. #4084 is still open to fix the actual bug, now labeled priority.

@pjcozzi pjcozzi closed this as completed Jan 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue An opportunity for first time contributors type - bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pjcozzi @mramato