Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Either UniformState or FrameState is in the wrong module... #466

Open
mramato opened this issue Jan 17, 2013 · 3 comments · May be fixed by gsoc2/cesium#1
Open

Either UniformState or FrameState is in the wrong module... #466

mramato opened this issue Jan 17, 2013 · 3 comments · May be fixed by gsoc2/cesium#1
Assignees
@pjcozzi
Labels
breaking change cleanup

Comments

@mramato
Copy link
Contributor

mramato commented Jan 17, 2013

UniformState is in Renderer, but FrameState is in Scene. Since UniformState depends on FrameState, shouldn't FrameState be moved to Renderer?
@mramato
Copy link
Contributor Author

mramato commented Jan 17, 2013

CC @pjcozzi

@pjcozzi
Copy link
Contributor

pjcozzi commented Jan 17, 2013

I'm aware. This will be cleaned up as we continue to work on the DDR.

@pjcozzi pjcozzi added the 1.0 label May 8, 2014
@pjcozzi
Copy link
Contributor

pjcozzi commented Jun 30, 2014

Pushing post 1.0. This change is too involved, is for now @private types, and would only affect AMD users.

@pjcozzi pjcozzi added 1.0 push and removed 1.0 labels Jun 30, 2014
@pjcozzi pjcozzi self-assigned this Oct 6, 2014
@pjcozzi pjcozzi added 2.0 and removed 1.0 push labels Jan 2, 2017
@pjcozzi pjcozzi removed the 2.0 label Jun 14, 2017
@gitworkflows gitworkflows linked a pull request Jan 19, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjcozzi pjcozzi

Labels
breaking change cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Upgrade @zip.js/zip.js from 2.4.26 to 2.7.32 gsoc2/cesium
2 participants
@pjcozzi @mramato