Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lens Flare artifact #5932

Open
bagnell opened this issue Oct 25, 2017 · 5 comments
Open

Lens Flare artifact #5932

bagnell opened this issue Oct 25, 2017 · 5 comments

Comments

@bagnell
Copy link
Contributor

bagnell commented Oct 25, 2017

From the post-processing-1.0 branch, open the Lens Flare Sandcastle example and click View from Everest. You'll see this:

image

Any ideas how to fix this @byumjin?

CC #5615

@byumjin
Copy link
Contributor

byumjin commented Oct 26, 2017

Sorry, there is no way to fix it
Because, it uses the scene image for its ghost effects, not the HDR scene image (only bright part).
Thus, only space scene could show the appropriate result :(

@pjcozzi
Copy link
Contributor

pjcozzi commented Oct 26, 2017

Thanks @byumjin! We plan to implement HDR - will that fix this? Or will we need to do additional work once HDR is implemented?

@byumjin
Copy link
Contributor

byumjin commented Oct 26, 2017

it needs additional work creating a shader extracting bright color part from HDR instead of just using scene image.

@pjcozzi
Copy link
Contributor

pjcozzi commented Oct 26, 2017

Gotcha, thanks @byumjin!

@bagnell up to you if you want to just keep this as a known issue or add the disable workaround.

@lilleyse lilleyse mentioned this issue Dec 19, 2017
12 tasks
@bagnell
Copy link
Contributor Author

bagnell commented Jan 30, 2018

A temporary workaround was added in 500660d. The lens flare is disabled when not in space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants