Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipping planes broken in IE #6048

Closed
ggetz opened this issue Dec 12, 2017 · 7 comments · Fixed by #6201
Closed

Clipping planes broken in IE #6048

ggetz opened this issue Dec 12, 2017 · 7 comments · Fixed by #6201

Comments

@ggetz
Copy link
Contributor

ggetz commented Dec 12, 2017

See discussion in #6038.

There is an issue with the GLSL compilation in IE that disables clipping plane functionality.

@pjcozzi
Copy link
Contributor

pjcozzi commented Jan 2, 2018

For example:

http://localhost:8080/Apps/Sandcastle/index.html?src=3D Tiles Clipping Planes.html&label=All

aaa

@likangning93 perhaps your infinite clipping planes and clipping boxes will fix this...

@pjcozzi
Copy link
Contributor

pjcozzi commented Jan 2, 2018

Perhaps related to #6077

@pjcozzi
Copy link
Contributor

pjcozzi commented Jan 2, 2018

@likangning93 as part of your infinite clipping plane and box work, we also want to fix this (post 1.41) - which I think will just happen by moving from uniform arrays to textures - but also by adding the infrastructure to Model.js so that shaders can be recompiled to add/remove the clipping plane code like Globe currently does.

@lilleyse can help once everything else is done for infinite clipping planes/boxes.

@likangning93
Copy link
Contributor

Herm... not fixed yet, and also not working in Edge (although I don't think it's working in Edge in master either).

@likangning93
Copy link
Contributor

Okay. This should be fixed in #6201, but the bug wasn't just uniform arrays. See https://github.com/AnalyticalGraphicsInc/cesium/blob/master/Source/Shaders/Builtin/Functions/windowToEyeCoordinates.glsl#L34.

IE and Edge were always having this check (mat4 inequality) return false, which seems like a bug with their WebGL implementation.

@pjcozzi
Copy link
Contributor

pjcozzi commented Feb 15, 2018

Good catch, thanks @likangning93

@mramato
Copy link
Contributor

mramato commented Feb 26, 2018

Removing priority next release, this will come in with #6201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants