Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specs have deprecation warnings #6202

Closed
hpinkos opened this issue Feb 9, 2018 · 5 comments
Closed

Specs have deprecation warnings #6202

hpinkos opened this issue Feb 9, 2018 · 5 comments
Assignees

Comments

@hpinkos
Copy link
Contributor

hpinkos commented Feb 9, 2018

The specs use things like loadWithXhr and loadImage all over the place so now there are a bunch of deprecation warnings.

Marking this 'next release' because it should have been addressed in #6138

@tfili please take a look at this when you get a chance

@tfili
Copy link
Contributor

tfili commented Feb 9, 2018

I was told to leave the tests for the deprecated functions. There is an issue (#6119) to move all the load* tests into the Resource tests when they are removed. I should at least remove their usage in other tests.

@hpinkos
Copy link
Contributor Author

hpinkos commented Feb 9, 2018

I should at least remove their usage in other tests.

Thanks, yeah I agree.

@mramato
Copy link
Contributor

mramato commented Feb 11, 2018

There's no reason for this to be next release, it can just be done when the deprecated functions are removed. This is standard practice for us, it just so happens that there are a lot of deprecating functions this time around.

@hpinkos
Copy link
Contributor Author

hpinkos commented Feb 11, 2018

I don't know, every time I've deprecated something I've had to remove use of the deprecated function from the specs.

@mramato
Copy link
Contributor

mramato commented Feb 13, 2018

Yes, we try and remove usage in tests outside of the tests for the deprecated functionality itself, but we don't always catch them all. It's harmless for now and like I said will just come out when we actually remove the deprecated functionality. priority - next release should be reserved for things that actually impact the next release, this doesn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants