-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specs have deprecation warnings #6202
Comments
I was told to leave the tests for the deprecated functions. There is an issue (#6119) to move all the |
Thanks, yeah I agree. |
There's no reason for this to be next release, it can just be done when the deprecated functions are removed. This is standard practice for us, it just so happens that there are a lot of deprecating functions this time around. |
I don't know, every time I've deprecated something I've had to remove use of the deprecated function from the specs. |
Yes, we try and remove usage in tests outside of the tests for the deprecated functionality itself, but we don't always catch them all. It's harmless for now and like I said will just come out when we actually remove the deprecated functionality. |
The specs use things like
loadWithXhr
andloadImage
all over the place so now there are a bunch of deprecation warnings.Marking this 'next release' because it should have been addressed in #6138
@tfili please take a look at this when you get a chance
The text was updated successfully, but these errors were encountered: