Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log a warning message for eye dome lighting in IE/Edge #6543

Closed
likangning93 opened this issue May 1, 2018 · 2 comments
Closed

Log a warning message for eye dome lighting in IE/Edge #6543

likangning93 opened this issue May 1, 2018 · 2 comments

Comments

@likangning93
Copy link
Contributor

Eye dome lighting for point clouds doesn't work in IE/Edge due to lack of EXT_frag_depth, OES_texture_float, and WEBGL_draw_buffers extensions in WebGL 1.0.

Currently it just silently bypasses that code, but it should log an error.

@mramato
Copy link
Contributor

mramato commented May 1, 2018

We need to add a isDomeLightingSupported flag and use it in the Sandcastle example so users understand they need to check for it and what the best practices are. Simply logging to the console will go unnoticed for most users.

@bagnell
Copy link
Contributor

bagnell commented Jun 1, 2018

Edge has all of those extensions (also EXT_color_buffer_float which is required). If you open the eye dome lighting example in Edge it logs framebuffer incomplete errors.

I've run into this before with OIT where all of the extensions are supported but the framebuffer is incomplete. In the isSupported function, make sure all of the extensions are supported and create the framebuffer. Then return true if the framebuffer.status === WebGLConstants.FRAMEBUFFER_COMPLETE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants