Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imagery Layers Sandcastle fails to load Bing Maps Road #7524

Closed
OmarShehata opened this issue Jan 30, 2019 · 5 comments · Fixed by #8895
Closed

Imagery Layers Sandcastle fails to load Bing Maps Road #7524

OmarShehata opened this issue Jan 30, 2019 · 5 comments · Fixed by #8895
Labels
category - sandcastle good first issue An opportunity for first time contributors onramping

Comments

@OmarShehata
Copy link
Contributor

Go to https://cesiumjs.org/Cesium/Build/Apps/Sandcastle/?src=Imagery%20Layers%20Manipulation.html

Click "Bing maps road" from the drop down. Observe the blue globe. Observe:

An error occurred in "BingMapsImageryProvider": An error occurred while accessing https://dev.virtualearth.net/REST/v1/Imagery/Metadata/Road?jsonp=loadJsonp622672&incl=ImageryProviders&key=undefined.

I think that Sandcastle just needs to be updated since it works fine if you go to any Sandcastle and select Bing Maps Roads from the imagery widget?

@mramato
Copy link
Contributor

mramato commented Jan 30, 2019

This is because it's using BingMapsImageryProvider directly (and there's no BING key embedded in Cesium). The example should just be updated to either use ion or remove that particular provider.

@mramato mramato added good first issue An opportunity for first time contributors onramping category - sandcastle labels Jan 30, 2019
@abu271
Copy link

abu271 commented May 2, 2019

Hi @OmarShehata I can work on this issue, where is the file located?

@OmarShehata
Copy link
Contributor Author

@abuDarda97 this can be another easy fix - just go here:

https://github.com/AnalyticalGraphicsInc/cesium/blob/master/Apps/Sandcastle/gallery/Imagery%20Layers%20Manipulation.html#L118-L121

Replace that section with ion imagery, which can be created using createWorldImagery. An example of that here: https://cesiumjs.org/Cesium/Build/Apps/Sandcastle/?src=Imagery%20Layers.html

Then just double check it looks the same as the default imagery in Cesium, and open the PR!

@mramato
Copy link
Contributor

mramato commented May 15, 2020

Cam up again here: #7128 (comment)

Our examples should be the last place we let trivial bugs linger, it would be good if someone opened a PR to fix this.

@NaorYael
Copy link

NaorYael commented Aug 9, 2023

In my case the key expired, try generate a new one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category - sandcastle good first issue An opportunity for first time contributors onramping
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants