Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the Timeline object is missing a destroy function #790

Closed
akosmaroy opened this issue May 23, 2013 · 3 comments
Closed

the Timeline object is missing a destroy function #790

akosmaroy opened this issue May 23, 2013 · 3 comments

Comments

@akosmaroy
Copy link
Contributor

thus I added one that removes all the event listeners, etc

see here: akosmaroy@3b665c3
@mramato
Copy link
Contributor

mramato commented May 23, 2013

Thanks @akosmaroy this was definitely on the to-do. Can you please make this change in a clean branch of master and open a pull request from there? This fix doesn't really belong in the batching branch and should be reviewed and merged separately. Especially since the batching branch won't be merged into master for some time. Thanks again.

@akosmaroy akosmaroy mentioned this issue May 27, 2013
Closed
@akosmaroy
Copy link
Contributor Author

as per your request, I moved these changes to the master branch, see pull request #798

@mramato
Copy link
Contributor

mramato commented Jun 18, 2013

Fixed with #874

@mramato mramato closed this as completed Jun 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akosmaroy @mramato