-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PerInstanceColorAppearance shader bug #8045
Comments
Thanks @nmschulte-aviture. @emackey @likangning93 @lilleyse, any of you have any thoughts here? |
I'm going to close this issue. Though I'm not sure what is causing the artifacts, the |
I believe there's still a bug here. I'll open a pull request and this issue if I find time to chase this down later. I probably misunderstand, but I think there's a bug here because a geometry should be able to provide more vertex attributes than what is required by the appearance and still be compatible. In my example, the |
Related to #8134 |
Oooh, thanks for elaborating @nmschulte-aviture |
In case it matters, I see this issue on Linux with both Intel and AMD hardware; Chromium, X.org, Mesa ( Intel
AMD
|
(Moved from #7947.)
I think
PerInstanceColorAppearance
's shaders have a problem: they applyst
attributes if they're set (for all instances)!PerInstanceColorAppearance
's documentation doesn't make note of this at all (though maybe it did in the past, given the documentation fix in #7947; df58cd1).Here is a demonstration; zoom in and rotate the camera about the two ellipses to see the strange rendering effect:
https://cesiumjs.org/Cesium/Apps/Sandcastle/index.html#c=xVRdb9owFP0rFi8NUuaEMUpLKRqi24TER1WqviwTMskteHPsyHbSson/PifBJGGatIdpy4OV63vO9bn3xMmIRBmFF5DoFnF4QRNQNI3xU7HnXIRFOBFcE8pBXrRvAp4ZjgqBg6GUXFyEJlUmSZIAkYSH0Cx6D3LKlc4TE8GEHJ9wTvtEpkdEk/oJRAxa7i3f+RFwhLbHXTSoYz8wRhMFllJCETIStWlzYGETIrV5I7yLn6WI72ArAZTzpt/Dvet+v++idz72u1dX3bZbVlAQ0zn5aoS/UmUK9fz8wX49Tfkp3W2mpdBEU8ErBXOid1iLBxIZFcq5NFh7lOdlYOS9fhQyJrqiPNV28Xg2K+CHkkW0lnSTmqYM3jadz7k5nmL05/McW66TC0bF0jkuZfVDwA+VS4QLvavs/G9mXfvWrLf/1qxuzaw/sOp+uZo+TpeL9WL5MB/P1uPF3Xr1+Pfd65zc83/jXnFVcSJpTDXNQGESRU79ktpM0zV7VK7us72j7vl38KVspbr/g1rg5hraNy23NVR6z2BUNvmexomQGqWSORh7GuKEETMGb5OG30DjUKlc+dCzpGFEM0Sj26B19ncKWihkRCmTeU4ZW9HvELRGQ8/gGzQmjIl8uzS+MbLPIbvOaFZuYoyHngl/ZWkh2IbIWsWf
The text was updated successfully, but these errors were encountered: