Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KML and clampToGround option #8239

Closed
lilleyse opened this issue Oct 2, 2019 · 3 comments
Closed

KML and clampToGround option #8239

lilleyse opened this issue Oct 2, 2019 · 3 comments

Comments

@lilleyse
Copy link
Contributor

lilleyse commented Oct 2, 2019

Similar KML to #8238 but with both tessellate and altitudeMode set so that the whole line should clamp to terrain. However it only clamps to terrain if options.clampToGround is true. Should it clamp to terrain automatically even if that option isn't passed in?

<?xml version="1.0" encoding="utf-8"?>
<kml xmlns="http://www.opengis.net/kml/2.2">
  <Document>
    <Folder>
      <Placemark>
        <LineString>
          <tessellate>1</tessellate>
          <altitudeMode>clampToGround</altitudeMode>
          <coordinates>-94.2853118971204,34.0604044149558,200.0
            -95.2849440296246,34.0600224952286,200.0</coordinates>
        </LineString>
      </Placemark>
    </Folder>
  </Document>
</kml>

Sandcastle (will need to replace url with a different url)

@mramato
Copy link
Contributor

mramato commented Oct 2, 2019

It is clamping to the ellipsoid or not clamping at all?

Should it clamp to terrain automatically even if that option isn't passed in?

No, the entire reason clampToGround is optional is because ground primitives have caveats that need to be addressed before we basically just turn it on by default everywhere (i.e. terrain on by default)

@lilleyse
Copy link
Contributor Author

lilleyse commented Oct 2, 2019

It is clamping to the ellipsoid or not clamping at all?

It's setting the height values to zero and not using ground polylines.

No, the entire reason clampToGround is optional is because ground primitives have caveats that need to be addressed before we basically just turn it on by default everywhere (i.e. terrain on by default)

Ah, ok. I added a checkbox to #5942

@lilleyse lilleyse closed this as completed Oct 2, 2019
@lilleyse
Copy link
Contributor Author

lilleyse commented Oct 2, 2019

Also - the original KML snippet I posted had 0.0 heights but I changed those to 200.0. Ultimately the heights are replaced with 0.0 but it's clearer that it happens if the source heights are not 0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants