Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Significant polyline artifacts with log depth off #8366

Closed
mramato opened this issue Nov 6, 2019 · 2 comments · Fixed by #8368
Closed

Significant polyline artifacts with log depth off #8366

mramato opened this issue Nov 6, 2019 · 2 comments · Fixed by #8368

Comments

@mramato
Copy link
Contributor

mramato commented Nov 6, 2019

I noticed a bad artifact on iOS and traced it back to all systems if you disable logDepth.

  1. Run this Sandcastle on any system https://sandcastle.cesium.com/index.html#c=tVPJbtswEP0VQhfJgEvJDRygrmI0sQ89FOhBRU66TKiRRXREBlwUOIX/vaQkN07aAr10AEHkLG/eLBzAsEHiExp2wxQ+sR1a6Xt+P+qyVIzXnVYOpEKTLtmPWrEgttOemlsle3DINswZj7U6LT7WqlYTIrcCFXLSBzDSdb0Ue3x03Z1v2zFdC2Rx9K9ANQKsI+TQNHtswZP7pjU9gLnzzmmVpVXIQyQd2kCi9Uo4GdSLM585ZQMOKu1N4B2hsrmc3XNP+1+mQAmaLOU8r6B/JIyW3Mp45CJ4poupjAtcAT0a4C0dP+sesyI6zMW+Jv+G9T12UhD+H8oz+N84T+2fmVt0cabZnDtKg9ZJBZHUhp0HvwMTWixBXfHW6H6PB4Nos3er1TVfv1+yqzUvwu/DuiiKxfIFTBuJYUkmsIskUTqERqrDhl2/6E/T8fTnRhoMfOOK/EvTDPZ6wFuibAQLX7JMSuuOhNsp6FOYrTaOeUNZaKHD0MKwTjZ/8OI7Oi6sjaFlfg4qGzkw2dzUyZsHUCdMEFgbLK0nquQz1sm2zIP/q7A4rlDy1wENwTG6dKvtl0nJOS/zcP09yk3Lc4FYq58

  2. Hit pause and manually zoom into agi

  3. At some point, two orbit lines will appear on screen and be drawn as if they were statically on screen, they shouldn't be there and are no where near the view.

image

@lilleyse this affects all iOS devices and any device that doesn't use logDepth. There seems to be a lot of regressions in this area lately. What can we do to ensure devices without logDepth continue to work as expected?

@OmarShehata
Copy link
Contributor

This looks like it's the same as #8356, where those polylines are actually showing through the globe.

The points on the opposite side of the globe are rendered in the last frustum which is past the depth plane. The same thing happened in 1.62 but the points would get overwritten by globe commands in closer frustums.

#8356 (comment)

@lilleyse
Copy link
Contributor

lilleyse commented Nov 6, 2019

Yes it's the same as #8356. Since we're doing the patch release already I can revert back to the old behavior and fix it before the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants