Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point covers entire screen when hidden #8479

Closed
lilleyse opened this issue Dec 19, 2019 · 0 comments · Fixed by #8538
Closed

Point covers entire screen when hidden #8479

lilleyse opened this issue Dec 19, 2019 · 0 comments · Fixed by #8538

Comments

@lilleyse
Copy link
Contributor

Sandcastle - looks good until you uncheck Other/Unclassified. This is a linux only bug. The way we hide points in PointCloud.js is to multiply gl_Position by 0.0 and hope the point is outside the clip space cube, but I could see how gl_Position.x / gl_Position.w (i.e. 0 / 0) might be undefined behavior. A better fix is to explicitly change the xyz coordinates to be greater than the w value so it clearly gets clipped. It would be nice to do this without the if statement though.

        if (hasShowStyle) {
            vs += '    if (show == 0.0) \n' +
                  '    { \n' +
                  '        gl_Position.xyz = vec3(gl_Position.w * 2.0); \n' +
                  '    } \n';
        }

Whatever we go with here we should test with every other system that hides points, like #7557 (comment). Look for any code that hides points by doing *= show and switch to the new approach.

1
2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant