Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyline regression in 1.67? #8663

Closed
mramato opened this issue Mar 5, 2020 · 4 comments · Fixed by #8703
Closed

Polyline regression in 1.67? #8663

mramato opened this issue Mar 5, 2020 · 4 comments · Fixed by #8703

Comments

@mramato
Copy link
Contributor

mramato commented Mar 5, 2020

Load simple.czml and zoom to GeoEye (after animating some so it's partially through the orbit)

image

In the above view, the polyline is clipped (the line moving towards the left should go all the way to the end of the screen) and there is also some weird break in the distance on the right (this should be one long continuous polyline)

Any ideas? @kring @lilleyse

@kring
Copy link
Member

kring commented Mar 5, 2020

I haven't found a view where I can see that break on the right, but the clipping on the left could be a result of the log depth changes. When I turn off log depth it looks the same in 1.66 and 1.67 (though kinda dodgy in both), but with log depth enabled it's clipped sooner in 1.67. I'll take a look.

@allinempty
Copy link

allinempty commented Mar 20, 2020

I run into the same issue. The polylines are 2 meters above the road but they are clipped.

image

@OmarShehata
Copy link
Contributor

OmarShehata commented Mar 20, 2020

@allinempty what version of CesiumJS are you testing? Does this produce the expected behavior in 1.66?

I'm not sure this is a regression. I can reproduce in 1.66:

https://cesium.com/downloads/cesiumjs/releases/1.66/Apps/Sandcastle/index.html?src=CZML.html

Turning off log depth with viewer.scene.logarithmicDepthBuffer = false; does fix it though.

@allinempty
Copy link

@OmarShehata I can reproduce it in both 1.66 and 1.67. Turning off log depth can fix it in both version. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants