Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type definition error for HeadingPitchRoll #8911

Closed
vla9isla8 opened this issue Jun 4, 2020 · 4 comments
Closed

Type definition error for HeadingPitchRoll #8911

vla9isla8 opened this issue Jun 4, 2020 · 4 comments
Labels
category - typescript

Comments

@vla9isla8
Copy link

Can`t access to HeadingPitchRoll fields.

Property 'heading' does not exist on type 'HeadingPitchRoll'. TS2339
@vla9isla8 vla9isla8 changed the title Type defenition error for HeadingPitchRoll Type definition error for HeadingPitchRoll Jun 4, 2020
@mramato
Copy link
Contributor

mramato commented Jun 4, 2020

Thanks @vla9isla8 this is a glaring bug in our JSDoc which went uncaught until now. They are missing in https://cesium.com/docs/cesiumjs-ref-doc/HeadingPitchRoll.html as well.

I'll open a PR to fix this and it will go out with a CesiumJS 1.70.1 patch release we are going to do early next week, specifically to support these initial TS issues.

Thanks again.

@mramato mramato mentioned this issue Jun 4, 2020
Merged
@vla9isla8
Copy link
Author

Great news! Thank you!

@Crocsx
Copy link

Crocsx commented Jun 7, 2020

Perfect news, looking forward to 1.70.1

@mramato
Copy link
Contributor

mramato commented Jun 10, 2020

This was fixed by the above PR (and 1.70.1 was released earlier today).

@mramato mramato closed this as completed Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category - typescript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mramato @OmarShehata @Crocsx @vla9isla8