-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diverse typescript types errors #8924
Comments
Thanks for taking the time to write this up @Crocsx! Your feedback is really appreciated.
Cesium.sampleTerrain(terrainProvider, 11, positions)
.then(function(updatedPositions) {
// positions[0].height and positions[1].height have been updated.
// updatedPositions is just a reference to positions.
})); Since technically, Promise.resolve(Cesium.sampleTerrain(terrainProvider, 11, positions))
.then(function(updatedPositions) {
// positions[0].height and positions[1].height have been updated.
// updatedPositions is just a reference to positions.
})); I left off the
Good catch, we just added the ability to create some smokescreen tests for TypeScript and I think all of the geometries are an excellent candidate for testing here. We'll fix this and add some tests to make sure they maintain the correct interface in TS going forward.
Happy to say that this one is already fixed by #8908 in master. I'll let you know once the PR for number 2 is open and we should be able to get it into a 1.70.1 patch release we're doing this week specifically for TypeScript bugfixes and improvements. Thanks again! |
Started looking into 2 and it's a bit more nuanced than I thought. Basically in some cases we take both the geometry type, i.e. We don't clearly define this anywhere and it's definitely confusing from an API naming situation. The best solution is most likely to define a new type out of whole cloth called |
@mramato thank for the reply. Thanks you for the update and the future 1.70.1. |
@mramato I think we should just expose It means we'll have to deprecate it later, but switching out the promise implementation is a big breaking change anyway, if for no other reason then because calls to |
What I don't understand is how is using |
|
@mramato I would like to add that in this issues => #8922
as been modified to
but I believe that since 1.10 there is a method (that I use in my angular app)
at the moment this return an error
|
I have the same problem |
Trackback to #9297, more interactions between TS and |
Hello,
Thanks for bringing in built in types in cesium, it's a really nice addition
I have the following thing that I believe is missing (and other but the issues are already posted).
when
fromCesium
like in this code :
I can't do this anymore, which I believe should work from the docs (https://cesium.com/docs/cesiumjs-ref-doc/GeometryInstance.html)
const newLayer = new ImageryLayer(new IonImageryProvider({ assetId: provider.id }));
The text was updated successfully, but these errors were encountered: