Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageryLayer does not accept various ImageryProviders #8938

Closed
rot1024 opened this issue Jun 9, 2020 · 2 comments
Closed

ImageryLayer does not accept various ImageryProviders #8938

rot1024 opened this issue Jun 9, 2020 · 2 comments

Comments

@rot1024
Copy link

rot1024 commented Jun 9, 2020

In Cesium.d.ts, some imagery providers do not satisfy ImageryProvider class type constrain.

const provider = new ArcGisMapServerImageryProvider({
  url: "//services.arcgisonline.com/ArcGIS/rest/services/World_Street_Map/MapServer",
});

const layer = new ImageryLayer(provider, { /* ... */ })
//                             ^^^^^^^^ Error!
// 'ArcGisMapServerImageryProvider' type is missing the following properties from type 'ImageryProvider': defaultNightAlpha, defaultDayAlpha ts(2739)

I confirmed ArcGisMapServerImageryProvider and IonImageryProvider are so, but perhaps there are other providers that is so.

@mramato
Copy link
Contributor

mramato commented Jun 9, 2020

Thanks @rot1024, this is already fixed in master and will go out with the 1.70.1 release later this week. See #8908 for the full details/changes if you're interested.

@mramato mramato closed this as completed Jun 9, 2020
@rot1024
Copy link
Author

rot1024 commented Jun 9, 2020

Thank you for quick reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants