Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cesiumWorkerBootstrapper does not have cache busting #9057

Open
jony89 opened this issue Jul 23, 2020 · 6 comments
Open

cesiumWorkerBootstrapper does not have cache busting #9057

jony89 opened this issue Jul 23, 2020 · 6 comments

Comments

@jony89
Copy link
Contributor

jony89 commented Jul 23, 2020

Latest cesium version has changed the file cesiumWorkerBootstrapper

yet under Build/Cesium/Workers/ the file cesiumWorkerBootstrapper does not have cache busting, i.e no hash to this file. most other files seems ok.

which caused to latest version to break until hard refresh is done.

@OmarShehata
Copy link
Contributor

Doesn't this apply to all files in the library that are served statically and fetched at runtime? And that could be something the application can handle based on how you're serving those files/by serving them under a folder like Cesium/1.71/Build/ etc.

@jony89
Copy link
Contributor Author

jony89 commented Jul 24, 2020

Doesn't this apply to all files in the library that are served statically and fetched at runtime?

True. yet, cesium is a bit different. since cesium is the one who fetches the files under /Workers and by that cesium lib requirement is to provide statically served files directly from the node_modules

This also can be seen on every cesium installation guide, especially with webpack

https://cesium.com/docs/tutorials/cesium-and-webpack/

See the lines here :

new CopywebpackPlugin([ { from: path.join(cesiumSource, cesiumWorkers), to: 'Workers' } ]),

So normally you are correct, the app installing the library should take care of the hashing and caching of the files, but some files in cesium are required to be fetched by cesium, so cesium library expects the files to be exist.

Also most of the files under /Workers do have cache busting, cesiumWorkerBootstrapper is one of the few files which does not.

@jony89
Copy link
Contributor Author

jony89 commented Aug 18, 2020

@mramato are you aware of this? I've looked into the gulp file and I saw that cesiumWorkerBootstrapper file is excluded from being minified and contain hashed file name, the file is also being hard coded consumed, which is problematic if the filename will contain hash.

@TJKoury
Copy link
Contributor

TJKoury commented Oct 9, 2020

Our distro, C137.js can help with this issue since you can cache bust the single file.

@Joebh
Copy link

Joebh commented Dec 1, 2022

+1 seeing this issue still in 1.97.0 Any thoughts on this?

@TJKoury
Copy link
Contributor

TJKoury commented Dec 1, 2022

Still working on what could be a solution here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants