Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

label show text "Piauí­" ,Will crash #9334

Closed
hemincan opened this issue Jan 20, 2021 · 2 comments · Fixed by #9682
Closed

label show text "Piauí­" ,Will crash #9334

hemincan opened this issue Jan 20, 2021 · 2 comments · Fixed by #9682

Comments

@thw0rted
Copy link
Contributor

Sandcastle hangs the browser tab when I open the demo, but I was able to grab the problem string. It is 50 69 61 75 ed ad in hex. That last character 0xAD is a soft hyphen which is normally not rendered. It definitely should not be in the label text, but also its inclusion should not cause Cesium to hang the browser.

Actually, I just realized that this already came up in #4918 (comment) but @mramato said it was fixed. Maybe they forgot to test for this specific character?

At any rate, IIRC, Label never auto-wraps text, which is the only purpose of this character, so simply stripping it from input strings should be the right course of action.

@hpinkos
Copy link
Contributor

hpinkos commented Jan 22, 2021

Thanks for including the Sancastle example @hemincan . I was able to reproduce this crash as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants