-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KHR_techniques_webgl missing after updating model from gltf v1.0 to gltf v2.0 #417
Comments
Yeah Cesium will be able to load those models once CesiumGS/cesium#6805 is merged. I'm not sure what the plan is for the validator or other engines. |
@lilleyse now that #6805 has been merged, do you know whether there's an easy way to preview glTF 2.0
I also get an error in VSCode. |
@emackey do you know what would need to be fixed from the VSCode side? I can't think of other viewers out there that are up to date. |
Is there a sample model that shows the problem? I tried running CesiumAir.gltf through the pipeline and the result seems to work in VSCode's Cesium preview. (It almost works in the ThreeJS preview, but the textures seem to be missing). Also, click the "Extensions" button in VSCode, and check that glTF-Tools says version 2.1.17 or higher. If not you will need to update VSCode and/or the extension. |
Actually the screenshot above looks like version 2.1.14. You'll need to update VSCode and then update the extension. |
I'm testing the VSCode extension 2.1.17 with Cesium, and https://www.virtualgis.io/gltfviewer/. The only result I see in VSCode is this: I'm not sure how to access the script error, though. Let me see if I can share the model. |
Yeah that script error message hides a much more informative error message. The message hiding was just fixed in AnalyticalGraphicsInc/gltf-vscode#127, but I haven't published since then. Need to do that soon. If you're able to share the model, I'd be happy to take a look. If you can't share the model, you can still dig into the error on your side, without building from source. Follow the steps in Debugging the HTML preview window in VSCode. Typically I open the glTF preview window, switch to an engine that doesn't have an error, then follow those steps to open up DevTools, turn on "Pause on caught exceptions" in the scripts tab, then switch back to the engine that gives an error. In this way DevTools is open when the error happens, and it breaks execution there. |
I can't share the model publicly, but emailed you a copy. Thanks! |
Has this been solved already? Thanks |
@katSchmid I think so, thanks for the ping |
I tried to update some gltf v1.0 models to v2.0 using this nice pipeline.
If I understood correctly, this pipeline does so by using KHR_techniques_webgl, which still seems to have draft status according the readme.
The validator as well as cesium complain about the not yet supported gltf extension, see:
Will the issue on the cesium side be solved, once this is merged?
CesiumGS/cesium#6805
What about the validator?
Have a nice weekend
The text was updated successfully, but these errors were encountered: