Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KHR_techniques_webgl missing after updating model from gltf v1.0 to gltf v2.0 #417

Closed
tkazik opened this issue Aug 18, 2018 · 10 comments
Closed

Comments

@tkazik
Copy link

tkazik commented Aug 18, 2018

I tried to update some gltf v1.0 models to v2.0 using this nice pipeline.
If I understood correctly, this pipeline does so by using KHR_techniques_webgl, which still seems to have draft status according the readme.

The validator as well as cesium complain about the not yet supported gltf extension, see:

gltf-pipeline

Will the issue on the cesium side be solved, once this is merged?
CesiumGS/cesium#6805

What about the validator?

Have a nice weekend

@lilleyse
Copy link
Contributor

Yeah Cesium will be able to load those models once CesiumGS/cesium#6805 is merged. I'm not sure what the plan is for the validator or other engines.

@donmccurdy
Copy link

@lilleyse now that #6805 has been merged, do you know whether there's an easy way to preview glTF 2.0 KHR_techniques_webgl in Cesium? I'm testing https://www.virtualgis.io/gltfviewer/ but getting:

RuntimeError: Unsupported glTF Extension: KHR_techniques_webgl

I also get an error in VSCode.

@lilleyse
Copy link
Contributor

@emackey do you know what would need to be fixed from the VSCode side?

I can't think of other viewers out there that are up to date.

@emackey
Copy link

emackey commented Nov 20, 2018

Is there a sample model that shows the problem? I tried running CesiumAir.gltf through the pipeline and the result seems to work in VSCode's Cesium preview. (It almost works in the ThreeJS preview, but the textures seem to be missing).

Also, click the "Extensions" button in VSCode, and check that glTF-Tools says version 2.1.17 or higher. If not you will need to update VSCode and/or the extension.

@emackey
Copy link

emackey commented Nov 20, 2018

Actually the screenshot above looks like version 2.1.14. You'll need to update VSCode and then update the extension.

@donmccurdy
Copy link

I'm testing the VSCode extension 2.1.17 with Cesium, and https://www.virtualgis.io/gltfviewer/. The only result I see in VSCode is this:

screen shot 2018-11-20 at 10 05 06 am

I'm not sure how to access the script error, though. Let me see if I can share the model.

@emackey
Copy link

emackey commented Nov 20, 2018

Yeah that script error message hides a much more informative error message. The message hiding was just fixed in AnalyticalGraphicsInc/gltf-vscode#127, but I haven't published since then. Need to do that soon.

If you're able to share the model, I'd be happy to take a look. If you can't share the model, you can still dig into the error on your side, without building from source. Follow the steps in Debugging the HTML preview window in VSCode. Typically I open the glTF preview window, switch to an engine that doesn't have an error, then follow those steps to open up DevTools, turn on "Pause on caught exceptions" in the scripts tab, then switch back to the engine that gives an error. In this way DevTools is open when the error happens, and it breaks execution there.

@donmccurdy
Copy link

I can't share the model publicly, but emailed you a copy. Thanks!

@katSchmid
Copy link

Has this been solved already? Thanks

@lilleyse
Copy link
Contributor

@katSchmid I think so, thanks for the ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants