Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning submissions #3

Closed
C1ares opened this issue Jan 9, 2023 · 6 comments
Closed

Cleaning submissions #3

C1ares opened this issue Jan 9, 2023 · 6 comments

Comments

@C1ares
Copy link

C1ares commented Jan 9, 2023

Hey, love the app! Makes using FA on the phone much less painful

Unfortunately though, I'm one of those people who like to not reach the highest possible numbers in the menubar, so after checking new submissions, I usually nuke them all

If there's no fundamental challenge in achieving this, I'd appreciate it a lot if you could look into adding this feature ^-^

@Ceylo
Copy link
Owner

Ceylo commented Jan 9, 2023

Hey @C1ares !

I used to do the same until mainly using this app so I can totally understand.

There's no major issue in doing this, I just avoided this kind of action till now since it's destructive and I wouldn't want the app to mess up a user's data.

How do you expect this to behave?

  • New submissions automatically cleaned up from your account after getting fetched by the app? Could work but you wouldn't be able to check them later on the website, also the app doesn't save (although it could be changed) in a persistent way the list of submissions, so if it gets killed/crashes/you restart your device, then you'd have lost your submission feed.
  • Manual removal: like Apple Mail app let's say, you can manually swipe one to remove it or Edit, Select all then delete. Might be a bit tricky to implement correctly since the feed is just based on the first 72 submissions listed on your account. So this "delete all" would only delete at most 72 items.
  • Just give access to Nuke All Submissions button from the app. Simple to implement. To make things consistent your feed in the app would then become empty.

@C1ares
Copy link
Author

C1ares commented Jan 10, 2023

Hi @Ceylo, thank you for the swift response!

Personally, a simple button to clear all submissions at the very bottom of the feed would work best, since I never had to keep any after I've viewed them

@Ceylo
Copy link
Owner

Ceylo commented Jan 10, 2023

Does it mean that you're browsing the feed from top to bottom? I'm going from "last viewed" to top, like one would use Twitter I guess.

The only thing I'm worried about with putting such button at the bottom of the feed is for the day where I add support to also browse the next pages from your submission list. This means that such button could be reaaaaally far down in that feed.

On the other hand it seems like a very minor use case: if you have thousands of submissions and want to nuke them you can go to the website once, while for a regular "Nuke" use like yours, I guess you'll never have more than 100 submissions in the feed. Do you confirm?

Edit: An alternative would be to have controls in top right like in Photos app when you zoom in your collection (the "…" for instance). 🤔
IMG_4363

@Ceylo
Copy link
Owner

Ceylo commented Jan 15, 2023

@C1ares this is coming in next release :)

nuke.mov

@C1ares
Copy link
Author

C1ares commented Jan 16, 2023

@C1ares this is coming in next release :)

nuke.mov

Looks great, thank you so much ^~^

@Ceylo
Copy link
Owner

Ceylo commented Jan 23, 2023

Fixed in version 1.5.0 of the app.

@Ceylo Ceylo closed this as completed Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants