#60 - Change button to link. #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing the Sign In button to a link so that a GET request is created as opposed to a POST. This prevents an error on loading the sign in page for the first time.
exegeteio
force-pushed
the
60-navbar-sign-in-not-post
branch
from
58772a6
to
d815a42
Compare
LOL! I'll merge it after you've made your four, but I don't think there's a way to exclude it. |
|
Please include the issue it closes with |
|
Also, it clearly passes Hacktoberfest quality standards. |
|
@exegeteio You ready for me to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the Sign In button to a link so that a GET request is created as opposed to a POST. This prevents an error on loading the sign in page for the first time.
Can this be marked as "too simple for Hacktoberfest" ? I don't think this should count.