Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade AES to use nodejs builtins #200

Open
acolytec3 opened this issue Aug 2, 2022 · 1 comment
Open

Upgrade AES to use nodejs builtins #200

acolytec3 opened this issue Aug 2, 2022 · 1 comment
Labels

Comments

@acolytec3
Copy link
Contributor

discv5 currently uses the bcrypto implementation of the AES ciphers and this can relatively painlessly be switched to use the nodejs builtin equivalents. This work was already done in #197 and should be easily pulled out into a standalone PR and appeared to provide a modest performance improvement at the same time.

Node builtins
✔ benchmark aes cipher encryption/decryptions 23322.53 ops/s 42.87700 us/op - 2322 runs 0.101 s

With bcrypto
✔ benchmark aes cipher encryption/decryptions 21194.07 ops/s 47.18300 us/op - 2137 runs 0.102 s

@dapplion
Copy link
Contributor

dapplion commented Aug 7, 2022

Sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants