Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure our enr has signature in INodesMessage response #229

Merged
merged 1 commit into from
Dec 28, 2022
Merged

fix: ensure our enr has signature in INodesMessage response #229

merged 1 commit into from
Dec 28, 2022

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Dec 26, 2022 •
edited
Loading

Motivation

  • When handling FindNodes request, if distance is 0 we always call this.enr.encodeToValues(privateKey) which sign the enr content, this is to make sure we have a signature in our enr
  • I debug a node running several days, the seq in enr is only 11n, it means that there are not a lot of modification that cause us to sign the enr

Description

  • Check signature before calling this.enr.encodeToValues
  • Add more comments

this could be related to #201

@twoeths twoeths requested a review from a team as a code owner December 26, 2022 01:35
@wemeetagain wemeetagain merged commit 71a917f into master Dec 28, 2022
@wemeetagain wemeetagain deleted the tuyen/improve-handleFindNode branch December 28, 2022 22:59
@github-actions github-actions bot mentioned this pull request Dec 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapplion dapplion dapplion approved these changes

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twoeths @wemeetagain @dapplion